[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_f
From: |
Peter Xu |
Subject: |
[Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn |
Date: |
Fri, 22 Feb 2019 11:14:13 +0800 |
We were pushing the context until right before running the gmainloop.
Now since we have everything unconditionally, we can move this
earlier.
One benefit is that now it's done even before init_done_sem, so as
long as the iothread user calls iothread_create() and completes, we
know that the thread stack is ready.
Signed-off-by: Peter Xu <address@hidden>
---
iothread.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/iothread.c b/iothread.c
index 9abdbace66..7b7cba5d04 100644
--- a/iothread.c
+++ b/iothread.c
@@ -53,7 +53,7 @@ static void *iothread_run(void *opaque)
IOThread *iothread = opaque;
rcu_register_thread();
-
+ g_main_context_push_thread_default(iothread->worker_context);
my_iothread = iothread;
iothread->thread_id = qemu_get_thread_id();
qemu_sem_post(&iothread->init_done_sem);
@@ -66,12 +66,11 @@ static void *iothread_run(void *opaque)
* changed in previous aio_poll()
*/
if (iothread->running && atomic_read(&iothread->run_gcontext)) {
- g_main_context_push_thread_default(iothread->worker_context);
g_main_loop_run(iothread->main_loop);
- g_main_context_pop_thread_default(iothread->worker_context);
}
}
+ g_main_context_pop_thread_default(iothread->worker_context);
rcu_unregister_thread();
return NULL;
}
--
2.17.1
- Re: [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore, (continued)
Re: [Qemu-devel] [PATCH 1/4] iothread: replace init_done_cond with a semaphore, Stefan Hajnoczi, 2019/02/27
[Qemu-devel] [PATCH 3/4] iothread: create main loop unconditionally, Peter Xu, 2019/02/21
[Qemu-devel] [PATCH 2/4] iothread: create the gcontext onconditionally, Peter Xu, 2019/02/21
[Qemu-devel] [PATCH 4/4] iothread: push gcontext earlier in the thread_fn,
Peter Xu <=
Re: [Qemu-devel] [PATCH 0/4] iothread: create gcontext unconditionally, Paolo Bonzini, 2019/02/22