[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/15] kbd-state: don't block auto-repeat events
From: |
Gerd Hoffmann |
Subject: |
[Qemu-devel] [PULL 01/15] kbd-state: don't block auto-repeat events |
Date: |
Fri, 22 Feb 2019 08:53:12 +0100 |
Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Daniel P. Berrangé <address@hidden>
Message-id: address@hidden
---
ui/kbd-state.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/ui/kbd-state.c b/ui/kbd-state.c
index ac14add70eab..f3ab2d7a665d 100644
--- a/ui/kbd-state.c
+++ b/ui/kbd-state.c
@@ -42,14 +42,18 @@ void qkbd_state_key_event(QKbdState *kbd, QKeyCode qcode,
bool down)
{
bool state = test_bit(qcode, kbd->keys);
- if (state == down) {
+ if (down == false /* got key-up event */ &&
+ state == false /* key is not pressed */) {
/*
- * Filter out events which don't change the keyboard state.
+ * Filter out suspicious key-up events.
*
- * Most notably this allows to simply send along all key-up
- * events, and this function will filter out everything where
- * the corresponding key-down event wasn't send to the guest,
- * for example due to being a host hotkey.
+ * This allows simply sending along all key-up events, and
+ * this function will filter out everything where the
+ * corresponding key-down event wasn't sent to the guest, for
+ * example due to being a host hotkey.
+ *
+ * Note that key-down events on already pressed keys are *not*
+ * suspicious, those are keyboard autorepeat events.
*/
return;
}
--
2.9.3
- [Qemu-devel] [PULL 09/15] spice: do not stop spice if VM is paused, (continued)
- [Qemu-devel] [PULL 09/15] spice: do not stop spice if VM is paused, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 13/15] qapi: document DisplayType enum, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 02/15] spice: set device address and device display ID in QXL interface, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 03/15] sdl2: drop qemu_input_event_send_key_qcode call, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 14/15] spice: use a default name for the server, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 10/15] char: move SpiceChardev and open_spice_port() to spice.h header, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 07/15] spice: avoid spice runtime assert, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 11/15] char: register spice ports after spice started, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 08/15] spice: merge options lists, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 05/15] char/spice: trigger HUP event, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 01/15] kbd-state: don't block auto-repeat events,
Gerd Hoffmann <=
- [Qemu-devel] [PULL 12/15] build-sys: add gio-2.0 check, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 06/15] char/spice: discard write() if backend is disconnected, Gerd Hoffmann, 2019/02/22
- [Qemu-devel] [PULL 15/15] display: add -display spice-app launching a Spice client, Gerd Hoffmann, 2019/02/22
- Re: [Qemu-devel] [PULL 00/15] Ui 20190222 patches, Peter Maydell, 2019/02/25