[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operand
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v1 2/7] s390x/tcg: Simplify disassembler operands initialization |
Date: |
Mon, 25 Feb 2019 13:20:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 25/02/2019 12.55, David Hildenbrand wrote:
> Let's simply initialization to 0.
>
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> target/s390x/translate.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/target/s390x/translate.c b/target/s390x/translate.c
> index 19072efec6..c646e50eb3 100644
> --- a/target/s390x/translate.c
> +++ b/target/s390x/translate.c
> @@ -6091,7 +6091,7 @@ static DisasJumpType translate_one(CPUS390XState *env,
> DisasContext *s)
> const DisasInsn *insn;
> DisasJumpType ret = DISAS_NEXT;
> DisasFields f;
> - DisasOps o;
> + DisasOps o = {};
>
> /* Search for the insn in the table. */
> insn = extract_insn(env, s, &f);
> @@ -6161,12 +6161,6 @@ static DisasJumpType translate_one(CPUS390XState *env,
> DisasContext *s)
> /* Set up the strutures we use to communicate with the helpers. */
> s->insn = insn;
> s->fields = &f;
> - o.g_out = o.g_out2 = o.g_in1 = o.g_in2 = false;
> - o.out = NULL;
> - o.out2 = NULL;
> - o.in1 = NULL;
> - o.in2 = NULL;
> - o.addr1 = NULL;
>
> /* Implement the instruction. */
> if (insn->help_in1) {
>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v1 1/7] s390x/tcg: RXE has an optional M3 field, (continued)