[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 7/9] qmp: Add announce-self command
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v5 7/9] qmp: Add announce-self command |
Date: |
Wed, 27 Feb 2019 07:53:36 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
"Dr. David Alan Gilbert (git)" <address@hidden> writes:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Add a qmp command that can trigger guest announcements.
>
> It uses its own announce-timer instance, and parameters
> passed to it explicitly in the command.
>
> Like most qmp commands, it's in the main thread/bql, so
> there's no racing with any outstanding timer.
>
> Based on work of Germano Veit Michel <address@hidden> and
> Vladislav Yasevich <address@hidden>
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> ---
[...]
> diff --git a/qapi/net.json b/qapi/net.json
> index 5face0c14b..c093087278 100644
> --- a/qapi/net.json
> +++ b/qapi/net.json
> @@ -707,3 +707,23 @@
> 'max': 'int',
> 'rounds': 'int',
> 'step': 'int' } }
> +
> +##
> +# @announce-self:
> +#
> +# Trigger generation of broadcast RARP frames to update network switches.
> +# This can be useful when network bonds fail-over the active slave.
> +#
> +# @params: AnnounceParameters giving timing and repetition count of announce
> +#
> +# Example:
> +#
> +# -> { "execute": "announce-self"
> +# "arguments": { "params:" {
> +# "initial": 50, "max": 550, "rounds": 10, "step": 50 } } }
> +# <- { "return": {} }
> +#
> +# Since: 4.0
> +##
> +{ 'command': 'announce-self',
> + 'data' : {'params': 'AnnounceParameters'} }
Any particular reason for the additional level of nesting within
"arguments"?
Here's how to avoid it:
{ 'command': 'announce-self', 'boxed': true,
'data' : 'AnnounceParameters' }
- [Qemu-devel] [PATCH v5 0/9] Network announce changes, Dr. David Alan Gilbert (git), 2019/02/26
- [Qemu-devel] [PATCH v5 1/9] net: Introduce announce timer, Dr. David Alan Gilbert (git), 2019/02/26
- [Qemu-devel] [PATCH v5 5/9] net: Add a network device specific self-announcement ability, Dr. David Alan Gilbert (git), 2019/02/26
- [Qemu-devel] [PATCH v5 6/9] virtio-net: Allow qemu_announce_self to trigger virtio announcements, Dr. David Alan Gilbert (git), 2019/02/26
- [Qemu-devel] [PATCH v5 3/9] virtio-net: Switch to using announce timer, Dr. David Alan Gilbert (git), 2019/02/26
- [Qemu-devel] [PATCH v5 2/9] migration: Add announce parameters, Dr. David Alan Gilbert (git), 2019/02/26
- [Qemu-devel] [PATCH v5 7/9] qmp: Add announce-self command, Dr. David Alan Gilbert (git), 2019/02/26
[Qemu-devel] [PATCH v5 4/9] migration: Switch to using announce timer, Dr. David Alan Gilbert (git), 2019/02/26
[Qemu-devel] [PATCH v5 8/9] hmp: Add hmp_announce_self, Dr. David Alan Gilbert (git), 2019/02/26
[Qemu-devel] [PATCH v5 9/9] tests: Add a test for qemu self announcements, Dr. David Alan Gilbert (git), 2019/02/26