[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 09/13] hmp: Add hmp_announce_self
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PULL 09/13] hmp: Add hmp_announce_self |
Date: |
Wed, 27 Feb 2019 09:28:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 |
On 22/02/2019 15.55, Jason Wang wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Add an HMP command to trigger self annocements.
> Unlike the QMP command (which takes a set of parameters), the HMP
> command reuses the set of parameters used for migration.
>
> Signend-off-by: Vladislav Yasevich <address@hidden>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> Reviewed-by: Michael S. Tsirkin <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> ---
> hmp-commands.hx | 14 ++++++++++++++
> hmp.c | 5 +++++
> hmp.h | 1 +
> tests/test-hmp.c | 1 +
> 4 files changed, 21 insertions(+)
>
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index ba71558..9f812bc 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -931,6 +931,20 @@ stops because the size limit is reached.
> ETEXI
>
> {
> + .name = "announce_self",
> + .args_type = "",
> + .params = "",
> + .help = "Trigger GARP/RARP announcements",
> + .cmd = hmp_announce_self,
> + },
> +
> +STEXI
> address@hidden announce_self
> address@hidden announce_self
> +Trigger GARP/RARP announcements.
> +ETEXI
The help text is incredibly sparse. I doubt that the average user
manages to find out the meaning of this command just by looking at this
short information. Also, shouldn't you mention here that the parameters
used for migration are re-used here, like in the patch description?
Thus, could you please send a follow-up patch to increase that
information here a little bit, please?
Thanks,
Thomas
- [Qemu-devel] [PULL 00/13] Netpatches, Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 02/13] net: Introduce announce timer, Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 05/13] migration: Switch to using announce timer, Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 13/13] net: netmap: improve netmap_receive_iov(), Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 11/13] net: netmap: small improvements netmap_send(), Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 09/13] hmp: Add hmp_announce_self, Jason Wang, 2019/02/22
- Re: [Qemu-devel] [PULL 09/13] hmp: Add hmp_announce_self,
Thomas Huth <=
- [Qemu-devel] [PULL 12/13] net: netmap: simplify netmap_receive(), Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 08/13] qmp: Add announce-self command, Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 06/13] net: Add a network device specific self-announcement ability, Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 10/13] tests: Add a test for qemu self announcements, Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 03/13] migration: Add announce parameters, Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 07/13] virtio-net: Allow qemu_announce_self to trigger virtio announcements, Jason Wang, 2019/02/22
- [Qemu-devel] [PULL 01/13] net/colo-compare.c: Remove duplicated code, Jason Wang, 2019/02/22