[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 0/2] target/i386: cpu.h macros clean up
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v5 0/2] target/i386: cpu.h macros clean up |
Date: |
Thu, 26 Sep 2019 17:17:22 -0300 |
On Thu, Sep 26, 2019 at 10:10:53AM +0800, Tao Xu wrote:
> Add some comments, clean up comments over 80 chars per line. There
> is an extra line in comment of CPUID_8000_0008_EBX_WBNOINVD, remove
> the extra enter and spaces.
>
> Drop the duplicated definition of cpuid AVX512_VBMI macro and rename it
> as CPUID_7_0_ECX_AVX512_VBMI. Rename CPUID_7_0_ECX_VBMI2
> as CPUID_7_0_ECX_AVX512_VBMI2.
>
Queued, thanks!
> Changelog:
> v5:
> - correct commit messages. (Suggested by Stefano Garzarella)
> v4:
> - rename CPUID_7_0_ECX_VBMI2 as CPUID_7_0_ECX_AVX512_VBMI2.
> (Suggested by Stefano Garzarella)
> v3:
> - split the patch into 2 patches. (Suggested by Stefano Garzarella
> and Eduardo Habkost)
> v2:
> - correct the comments over 80 chars per line. (Suggested by
> Philippe Mathieu-Daudé)
>
> Tao Xu (2):
> target/i386: clean up comments over 80 chars per line
> target/i386: drop the duplicated definition of cpuid AVX512_VBMI macro
>
> target/i386/cpu.c | 8 +-
> target/i386/cpu.h | 163 +++++++++++++++++++++++-------------
> target/i386/hvf/x86_cpuid.c | 2 +-
> 3 files changed, 111 insertions(+), 62 deletions(-)
>
> --
> 2.20.1
>
--
Eduardo