[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU hea
|
From: |
Richard Henderson |
|
Subject: |
Re: [PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU header target_flat.h |
|
Date: |
Fri, 20 Mar 2020 10:19:28 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 |
On 3/19/20 12:33 PM, Peter Maydell wrote:
> The target_flat.h file is a QEMU header, so we should include it using
> quotes, not angle brackets.
>
> Coverity otherwise is unable to find the header:
>
> "../linux-user/flatload.c", line 40: error #1712: cannot open source file
> "target_flat.h"
> #include <target_flat.h>
> ^
>
> because the relevant directory is only on the -iquote path, not the -I path.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> I don't know why Coverity in particular has trouble here but
> real compilers don't. Still, the "" is the right thing.
> ---
> linux-user/flatload.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [PATCH v2 0/6] Automation of Coverity Scan uploads (via Docker), Peter Maydell, 2020/03/19
- [PATCH v2 1/6] osdep.h: Drop no-longer-needed Coverity workarounds, Peter Maydell, 2020/03/19
- [PATCH v2 2/6] thread.h: Fix Coverity version of qemu_cond_timedwait(), Peter Maydell, 2020/03/19
- [PATCH v2 4/6] linux-user/flatload.c: Use "" for include of QEMU header target_flat.h, Peter Maydell, 2020/03/19
- [PATCH v2 3/6] thread.h: Remove trailing semicolons from Coverity qemu_mutex_lock() etc, Peter Maydell, 2020/03/19
- [PATCH v2 5/6] scripts/run-coverity-scan: Script to run Coverity Scan build, Peter Maydell, 2020/03/19
- [PATCH v2 6/6] scripts/coverity-scan: Add Docker support, Peter Maydell, 2020/03/19