[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 05/10] target/xtensa: add FIXME for translation memory lea
From: |
Max Filippov |
Subject: |
Re: [PATCH v2 05/10] target/xtensa: add FIXME for translation memory leak |
Date: |
Wed, 1 Apr 2020 15:58:30 -0700 |
On Wed, Apr 1, 2020 at 2:48 AM Alex Bennée <address@hidden> wrote:
>
> Dynamically allocating a new structure within the DisasContext can
> potentially leak as we can longjmp out of the translation loop (see
> test_phys_mem). The proper fix would be to use static allocation
> within the DisasContext but as the Xtensa translator imports it's code
> from elsewhere I leave that as an exercise for the maintainer.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Cc: Max Filippov <address@hidden>
> ---
> target/xtensa/translate.c | 5 +++++
> 1 file changed, 5 insertions(+)
Acked-by: Max Filippov <address@hidden>
--
Thanks.
-- Max
- [PATCH for 5.0 v2 00/10] A selection of sanitiser fixes, Alex Bennée, 2020/04/01
- [PATCH v2 01/10] elf-ops: bail out if we have no function symbols, Alex Bennée, 2020/04/01
- [PATCH v2 03/10] tests/tcg: remove extraneous pasting macros, Alex Bennée, 2020/04/01
- [PATCH v2 02/10] linux-user: protect fcntl64 with an #ifdef, Alex Bennée, 2020/04/01
- [PATCH v2 04/10] linux-user: more debug for init_guest_space, Alex Bennée, 2020/04/01
- [PATCH v2 05/10] target/xtensa: add FIXME for translation memory leak, Alex Bennée, 2020/04/01
- Re: [PATCH v2 05/10] target/xtensa: add FIXME for translation memory leak,
Max Filippov <=
- [PATCH v2 06/10] gdbstub: fix compiler complaining, Alex Bennée, 2020/04/01
- [PATCH v2 07/10] softfloat: Fix BAD_SHIFT from normalizeFloatx80Subnormal, Alex Bennée, 2020/04/01
- [PATCH v2 08/10] linux-user: factor out reading of /proc/self/maps, Alex Bennée, 2020/04/01
- [PATCH v2 09/10] linux-user: clean-up padding on /proc/self/maps, Alex Bennée, 2020/04/01
- [PATCH v2 10/10] linux-user: completely re-write init_guest_space, Alex Bennée, 2020/04/01