[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 8/8] memory: Delay the transaction pop() until commit completed
From: |
Peter Xu |
Subject: |
[PATCH 8/8] memory: Delay the transaction pop() until commit completed |
Date: |
Tue, 21 Apr 2020 12:21:08 -0400 |
This should be functionally the same as before, but this allows the
memory_region_transaction_depth to be non-zero during commit, which can help us
to do sanity check on misuses.
Since at it, fix an indentation issue on the bracket.
Signed-off-by: Peter Xu <address@hidden>
---
memory.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/memory.c b/memory.c
index 2f8dc9721f..357f7276ee 100644
--- a/memory.c
+++ b/memory.c
@@ -1089,8 +1089,7 @@ void memory_region_transaction_commit(void)
assert(memory_region_transaction_depth);
assert(qemu_mutex_iothread_locked());
- memory_region_transaction_pop();
- if (!memory_region_transaction_depth) {
+ if (memory_region_transaction_depth == 1) {
if (memory_region_update_pending) {
flatviews_reset();
@@ -1109,7 +1108,14 @@ void memory_region_transaction_commit(void)
}
ioeventfd_update_pending = false;
}
- }
+ }
+
+ /*
+ * Pop the depth at last, so that memory_region_transaction_depth will
+ * still be non-zero during committing. This can help us to do some sanity
+ * check within the process of committing.
+ */
+ memory_region_transaction_pop();
}
static void memory_region_destructor_none(MemoryRegion *mr)
--
2.24.1
- [PATCH 0/8] memory: Sanity checks memory transaction when releasing BQL, Peter Xu, 2020/04/21
- [PATCH 1/8] memory: Introduce memory_region_transaction_{push|pop}(), Peter Xu, 2020/04/21
- [PATCH 2/8] memory: Don't do topology update in memory finalize(), Peter Xu, 2020/04/21
- [PATCH 4/8] cpus: Introduce qemu_cond_timedwait_iothread(), Peter Xu, 2020/04/21
- [PATCH 3/8] cpus: Use qemu_cond_wait_iothread() where proper, Peter Xu, 2020/04/21
- [PATCH 5/8] cpus: Remove the mutex parameter from do_run_on_cpu(), Peter Xu, 2020/04/21
- [PATCH 6/8] cpus: Introduce qemu_mutex_unlock_iothread_prepare(), Peter Xu, 2020/04/21
- [PATCH 7/8] memory: Assert on no ongoing memory transaction before release BQL, Peter Xu, 2020/04/21
- [PATCH 8/8] memory: Delay the transaction pop() until commit completed,
Peter Xu <=