[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 02/15] qapi: Fix the virtual walk example in visitor.h's big c
From: |
Markus Armbruster |
Subject: |
[PATCH v2 02/15] qapi: Fix the virtual walk example in visitor.h's big comment |
Date: |
Fri, 24 Apr 2020 10:43:25 +0200 |
Call visit_check_list(). Missed in commit a4a1c70dc7 "qapi: Make
input visitors detect unvisited list tails".
Drop an irrelevant error_propagate() while there.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
include/qapi/visitor.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h
index f8a0fc1ea9..7f63e4c381 100644
--- a/include/qapi/visitor.h
+++ b/include/qapi/visitor.h
@@ -215,6 +215,9 @@
* goto outlist;
* }
* outlist:
+ * if (!err) {
+ * visit_check_list(v, &err);
+ * }
* visit_end_list(v, NULL);
* if (!err) {
* visit_check_struct(v, &err);
@@ -222,7 +225,6 @@
* outobj:
* visit_end_struct(v, NULL);
* out:
- * error_propagate(errp, err);
* visit_free(v);
* </example>
*/
--
2.21.1
- [PATCH v2 00/15] qapi: Spring cleaning, Markus Armbruster, 2020/04/24
- [PATCH v2 03/15] qapi: Fix typo in visit_start_list()'s contract, Markus Armbruster, 2020/04/24
- [PATCH v2 01/15] qapi: Belatedly update visitor.h's big comment for QAPI modules, Markus Armbruster, 2020/04/24
- [PATCH v2 04/15] qapi: Document @errp usage more thoroughly in visitor.h, Markus Armbruster, 2020/04/24
- [PATCH v2 02/15] qapi: Fix the virtual walk example in visitor.h's big comment,
Markus Armbruster <=
- [PATCH v2 11/15] qapi: Assert non-input visitors see only valid alternate tags, Markus Armbruster, 2020/04/24
- [PATCH v2 13/15] qom: Simplify object_property_get_enum(), Markus Armbruster, 2020/04/24
- [PATCH v2 06/15] qapi: Assert incomplete object occurs only in dealloc visitor, Markus Armbruster, 2020/04/24
- [PATCH v2 09/15] qapi: Assert non-input visitors see only valid narrow integers, Markus Armbruster, 2020/04/24
- [PATCH v2 14/15] qapi: Disallow qmp_marshal_FOO(NULL, ...), Markus Armbruster, 2020/04/24
- [PATCH v2 10/15] qapi: Clean up visitor's recovery from input with invalid type, Markus Armbruster, 2020/04/24