[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] python: update type hints for mypy 0.930
From: |
Beraldo Leal |
Subject: |
Re: [PATCH 3/3] python: update type hints for mypy 0.930 |
Date: |
Mon, 10 Jan 2022 18:20:26 -0300 |
On Mon, Jan 10, 2022 at 02:13:49PM -0500, John Snow wrote:
> Mypy 0.930, released Dec 22, changes the way argparse objects are
> considered. Crafting a definition that works under Python 3.6 and an
> older mypy alongside newer versions simultaneously is ... difficult,
> so... eh. Stub it out with an 'Any' definition to get the CI moving
> again.
>
> Oh well.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> python/qemu/qmp/qom_common.py | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/python/qemu/qmp/qom_common.py b/python/qemu/qmp/qom_common.py
> index a59ae1a2a1..2e4c741f77 100644
> --- a/python/qemu/qmp/qom_common.py
> +++ b/python/qemu/qmp/qom_common.py
> @@ -30,10 +30,6 @@
> from . import QEMUMonitorProtocol, QMPError
>
>
> -# The following is needed only for a type alias.
> -Subparsers = argparse._SubParsersAction # pylint: disable=protected-access
> -
> -
> class ObjectPropertyInfo:
> """
> Represents the return type from e.g. qom-list.
> @@ -89,7 +85,7 @@ def __init__(self, args: argparse.Namespace):
> self.qmp.connect()
>
> @classmethod
> - def register(cls, subparsers: Subparsers) -> None:
> + def register(cls, subparsers: Any) -> None:
> """
> Register this command with the argument parser.
>
> --
> 2.31.1
>
>
Reviewed-by: Beraldo Leal <bleal@redhat.com>
--
Beraldo