[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 2/2] hw/i386: Make pic a property of common x86 base machi
|
From: |
Sergio Lopez |
|
Subject: |
Re: [PATCH v1 2/2] hw/i386: Make pic a property of common x86 base machine type |
|
Date: |
Tue, 11 Jan 2022 12:08:47 +0100 |
On Tue, Jan 11, 2022 at 03:35:28PM +0800, Xiaoyao Li wrote:
> Legacy PIC (8259) cannot be supported for TDX guests since TDX module
> doesn't allow directly interrupt injection. Using posted interrupts
> for the PIC is not a viable option as the guest BIOS/kernel will not
> do EOI for PIC IRQs, i.e. will leave the vIRR bit set.
>
> Make PIC the property of common x86 machine type. Hence all x86
> machines, including microvm, can disable it.
>
> Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> ---
> hw/i386/microvm.c | 27 +--------------------------
> hw/i386/pc_piix.c | 4 +++-
> hw/i386/pc_q35.c | 4 +++-
> hw/i386/x86.c | 25 +++++++++++++++++++++++++
> include/hw/i386/microvm.h | 2 --
> include/hw/i386/x86.h | 2 ++
> 6 files changed, 34 insertions(+), 30 deletions(-)
Reviewed-by: Sergio Lopez <slp@redhat.com>
signature.asc
Description: PGP signature