qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] hw/display/artist: allow to disable/enable cursor


From: Gerd Hoffmann
Subject: Re: [PATCH 2/3] hw/display/artist: allow to disable/enable cursor
Date: Tue, 25 Jan 2022 09:11:38 +0100

> @@ -1419,7 +1424,7 @@ static int vmstate_artist_post_load(void *opaque, int 
> version_id)
>  
>  static const VMStateDescription vmstate_artist = {
>      .name = "artist",
> -    .version_id = 1,
> +    .version_id = 2,

Which machines use that device?  Usually we try avoid bumping the
version as this is a one-way ticket (migration to newer versions works,
but back to older doesn't).  But for machine typess which are not
versioned this isn't that much of a problem.

>      .minimum_version_id = 1,
>      .post_load = vmstate_artist_post_load,
>      .fields = (VMStateField[]) {
> @@ -1440,6 +1445,7 @@ static const VMStateDescription vmstate_artist = {
>          VMSTATE_UINT32(line_end, ARTISTState),
>          VMSTATE_UINT32(line_xy, ARTISTState),
>          VMSTATE_UINT32(cursor_pos, ARTISTState),
> +        VMSTATE_UINT32(cursor_cntl, ARTISTState),

You need another variant of that macro (VMSTATE_UINT32_V() IIRC) to
declare that field as "new in v2".

take care,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]