Re: [PATCH v2 03/40] bsd-user/arm/signal.c: Implement setup_sigframe_arch for arm

[Richard Henderson]

On 1/25/22 12:29, Warner Losh wrote:
> Fix the broken context setting for arm. FreeBSD's get_mcontext does not
> fill in the vfp info. It's filled in in sigframe(). This corresponds to
> the new setup_sigframe_arch which fills in mcontext, then adjusts it to
> point to the vfp context in the sigframe and fills in that context as
> well. Add pointer to where this code is done.
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
>   bsd-user/arm/signal.c               | 50 +++++++++++++++++++----------
>   bsd-user/freebsd/target_os_signal.h |  2 +-
>   2 files changed, 34 insertions(+), 18 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> diff --git a/bsd-user/freebsd/target_os_signal.h 
> b/bsd-user/freebsd/target_os_signal.h
> index 7491629477a..43700d08f71 100644
> --- a/bsd-user/freebsd/target_os_signal.h
> +++ b/bsd-user/freebsd/target_os_signal.h
> @@ -4,7 +4,7 @@
>   #include "target_os_siginfo.h"
>   #include "target_arch_signal.h"
>   
> -abi_long setup_sigframe_arch(CPUArchState *regs, abi_ulong frame_addr,
> +abi_long setup_sigframe_arch(CPUArchState *env, abi_ulong frame_addr,
>                                struct target_sigframe *frame, int flags);
>   
>   /* Compare to sys/signal.h */

Should be in patch 2.


r~