qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 31/40] bsd-user/signal.c: setup_frame


From: Warner Losh
Subject: Re: [PATCH v2 31/40] bsd-user/signal.c: setup_frame
Date: Thu, 27 Jan 2022 08:30:54 -0700



On Thu, Jan 27, 2022 at 12:47 AM Richard Henderson <richard.henderson@linaro.org> wrote:
On 1/25/22 12:29, Warner Losh wrote:
> setup_frame sets up a signalled stack frame. Associated routines to
> extract the pointer to the stack frame and to support alternate stacks.
>
> Signed-off-by: Stacey Son<sson@FreeBSD.org>
> Signed-off-by: Kyle Evans<kevans@freebsd.org>
> Signed-off-by: Warner Losh<imp@bsdimp.com>
> ---
>   bsd-user/main.c   |  5 +++
>   bsd-user/qemu.h   |  3 +-
>   bsd-user/signal.c | 82 +++++++++++++++++++++++++++++++++++++++++++++++
>   3 files changed, 89 insertions(+), 1 deletion(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


> +#if defined(TARGET_ARM)
> +    return (sp - frame_size) & ~7;
> +#elif defined(TARGET_AARCH64)
> +    return (sp - frame_size) & ~15;
> +#else
> +    return sp - frame_size;
> +#endif

Just double-checking that this is still in the cleanup queue.
I would expect x86 to require 16 byte alignment as well, for sse

I'll add

/* TODO: make this a target_arch function / define */

to make it clear that it's still on the list...  Thanks for the reminder. There's
a lot on the list, alas...

 Warner



r~

reply via email to

[Prev in Thread] Current Thread [Next in Thread]