qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/10] python/aqmp: split _client_connected_cb() out as _inco


From: Daniel P . Berrangé
Subject: Re: [PATCH 04/10] python/aqmp: split _client_connected_cb() out as _incoming()
Date: Fri, 4 Mar 2022 17:53:00 +0000
User-agent: Mutt/2.1.5 (2021-12-30)

On Fri, Feb 25, 2022 at 03:59:42PM -0500, John Snow wrote:
> As part of disentangling the monolithic nature of _do_accept(), split
> out the incoming callback to prepare for factoring out the "wait for a
> peer" step. Namely, this means using an event signal we can wait on from
> outside of this method.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>  python/qemu/aqmp/protocol.py | 83 +++++++++++++++++++++++++-----------
>  1 file changed, 58 insertions(+), 25 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




reply via email to

[Prev in Thread] Current Thread [Next in Thread]