[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 18/60] target/arm: Use tcg_constant in translate-m-nocp.c
From: |
Peter Maydell |
Subject: |
Re: [PATCH v3 18/60] target/arm: Use tcg_constant in translate-m-nocp.c |
Date: |
Thu, 21 Apr 2022 20:03:13 +0100 |
On Sun, 17 Apr 2022 at 19:02, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Use tcg_constant_{i32,i64} as appropriate throughout.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/arm/translate-m-nocp.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/target/arm/translate-m-nocp.c b/target/arm/translate-m-nocp.c
> index d9e144e8eb..27363a7b4e 100644
> --- a/target/arm/translate-m-nocp.c
> +++ b/target/arm/translate-m-nocp.c
> @@ -173,7 +173,7 @@ static bool trans_VSCCLRM(DisasContext *s, arg_VSCCLRM *a)
> }
>
> /* Zero the Sregs from btmreg to topreg inclusive. */
> - zero = tcg_const_i64(0);
> + zero = tcg_constant_i64(0);
> if (btmreg & 1) {
> write_neon_element64(zero, btmreg >> 1, 1, MO_32);
> btmreg++;
Looks like we were previously leaking the TCGv for this one?
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- Re: [PATCH v3 17/60] target/arm: Use tcg_constant in translate.c, (continued)
- [PATCH v3 20/60] target/arm: Use smin/smax for do_sat_addsub_32, Richard Henderson, 2022/04/17
- [PATCH v3 12/60] target/arm: Split out gen_rebuild_hflags, Richard Henderson, 2022/04/17
- [PATCH v3 16/60] target/arm: Simplify aa32 DISAS_WFI, Richard Henderson, 2022/04/17
- [PATCH v3 15/60] target/arm: Simplify gen_sar, Richard Henderson, 2022/04/17
- [PATCH v3 18/60] target/arm: Use tcg_constant in translate-m-nocp.c, Richard Henderson, 2022/04/17
- Re: [PATCH v3 18/60] target/arm: Use tcg_constant in translate-m-nocp.c,
Peter Maydell <=
- [PATCH v3 32/60] target/arm: Update sysreg fields when redirecting for E2H, Richard Henderson, 2022/04/17
- [PATCH v3 22/60] target/arm: Use tcg_constant in translate-vfp.c, Richard Henderson, 2022/04/17
- [PATCH v3 21/60] target/arm: Use tcg_constant in translate-sve.c, Richard Henderson, 2022/04/17
- [PATCH v3 19/60] target/arm: Use tcg_constant in translate-neon.c, Richard Henderson, 2022/04/17