[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/10] Replace qemu_pipe() with g_unix_open_pipe()
From: |
Marc-André Lureau |
Subject: |
Re: [PATCH 06/10] Replace qemu_pipe() with g_unix_open_pipe() |
Date: |
Fri, 22 Apr 2022 13:09:30 +0400 |
Hi
On Fri, Apr 22, 2022 at 1:00 PM Daniel P. Berrangé <berrange@redhat.com> wrote:
>
> On Fri, Apr 22, 2022 at 12:36:35PM +0400, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > GLib g_unix_open_pipe() is essentially like qemu_pipe(), available since
> > 2.30.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > include/qemu/osdep.h | 4 ----
> > qemu-nbd.c | 5 +++--
> > util/event_notifier-posix.c | 2 +-
> > util/oslib-posix.c | 22 ----------------------
> > 4 files changed, 4 insertions(+), 29 deletions(-)
>
> There are a bunch of places still using 'pipe'instead of 'qemu_pipe'
> that should be switched also.
>
Ok, that would be a different patch though. Can you ack this one for now?
>
> With regards,
> Daniel
> --
> |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
> |: https://libvirt.org -o- https://fstop138.berrange.com :|
> |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
>
- [PATCH 00/10] Misc cleanups, marcandre . lureau, 2022/04/22
- [PATCH 01/10] Use QEMU_SANITIZE_THREAD, marcandre . lureau, 2022/04/22
- [PATCH 02/10] Use QEMU_SANITIZE_ADDRESS, marcandre . lureau, 2022/04/22
- [PATCH 03/10] include: move qemu_*_exec_dir() to cutils, marcandre . lureau, 2022/04/22
- [PATCH 04/10] tests: move libqtest.h back under qtest/, marcandre . lureau, 2022/04/22
- [PATCH 05/10] libqtest: split QMP part in libqmp, marcandre . lureau, 2022/04/22
- [PATCH 06/10] Replace qemu_pipe() with g_unix_open_pipe(), marcandre . lureau, 2022/04/22
- [PATCH 07/10] tests: make libqmp buildable for win32, marcandre . lureau, 2022/04/22
- [PATCH 08/10] Use g_unix_set_fd_nonblocking(), marcandre . lureau, 2022/04/22
- [PATCH 09/10] block: move fcntl_setfl(), marcandre . lureau, 2022/04/22
- [PATCH 10/10] util/win32: simplify qemu_get_local_state_dir(), marcandre . lureau, 2022/04/22