[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 26/54] configure: unify creation of cross-compilation Makefile
From: |
Stefan Hajnoczi |
Subject: |
Re: [PULL 26/54] configure: unify creation of cross-compilation Makefiles |
Date: |
Thu, 6 Oct 2022 16:33:02 -0400 |
On Tue, Oct 04, 2022 at 02:01:10PM +0100, Alex Bennée wrote:
> From: Paolo Bonzini <pbonzini@redhat.com>
>
> Let write_target_makefile handle both host and container cross compilers.
>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Message-Id: <20220929114231.583801-27-alex.bennee@linaro.org>
I think this commit breaks bisection:
configure: line 2498: syntax error near unexpected token `('
configure: line 2498: ` echo "run-tcg-tests-$target: $qemu\$(EXESUF)" >>
Makefile.prereqs'
It has already been merged into qemu.git/master, so there's no fixing it
now. I wanted to leave a comment in case someone hits this problem in
the future and wonders what's going on.
I had to use git bisect skip.
Stefan
>
> diff --git a/configure b/configure
> index cbeac99b2b..8b495d4453 100755
> --- a/configure
> +++ b/configure
> @@ -2157,51 +2157,49 @@ probe_target_compiler() {
>
> write_target_makefile() {
> echo "EXTRA_CFLAGS=$target_cflags"
> - if test -n "$target_cc"; then
> - echo "CC=$target_cc"
> - echo "CCAS=$target_ccas"
> - fi
> - if test -n "$target_ar"; then
> - echo "AR=$target_ar"
> - fi
> - if test -n "$target_as"; then
> - echo "AS=$target_as"
> - fi
> - if test -n "$target_ld"; then
> - echo "LD=$target_ld"
> - fi
> - if test -n "$target_nm"; then
> - echo "NM=$target_nm"
> - fi
> - if test -n "$target_objcopy"; then
> - echo "OBJCOPY=$target_objcopy"
> - fi
> - if test -n "$target_ranlib"; then
> - echo "RANLIB=$target_ranlib"
> - fi
> - if test -n "$target_strip"; then
> - echo "STRIP=$target_strip"
> - fi
> -}
> -
> -write_container_target_makefile() {
> - echo "$1: docker-image-$container_image" >> Makefile.prereqs
> - echo "EXTRA_CFLAGS=$target_cflags"
> - if test -n "$container_cross_cc"; then
> - echo "CC=$docker_py cc --cc $container_cross_cc -i qemu/$container_image
> -s $source_path --"
> - echo "CCAS=$docker_py cc --cc $container_cross_cc -i
> qemu/$container_image -s $source_path --"
> + if test -z "$target_cc" && test -z "$target_as"; then
> + test -z "$container_image" && error_exit "Internal error: could not find
> cross compiler for $1?"
> + echo "$1: docker-image-$container_image" >> Makefile.prereqs
> + if test -n "$container_cross_cc"; then
> + echo "CC=$docker_py cc --cc $container_cross_cc -i
> qemu/$container_image -s $source_path --"
> + echo "CCAS=$docker_py cc --cc $container_cross_cc -i
> qemu/$container_image -s $source_path --"
> + fi
> + echo "AR=$docker_py cc --cc $container_cross_ar -i qemu/$container_image
> -s $source_path --"
> + echo "AS=$docker_py cc --cc $container_cross_as -i qemu/$container_image
> -s $source_path --"
> + echo "LD=$docker_py cc --cc $container_cross_ld -i qemu/$container_image
> -s $source_path --"
> + echo "NM=$docker_py cc --cc $container_cross_nm -i qemu/$container_image
> -s $source_path --"
> + echo "OBJCOPY=$docker_py cc --cc $container_cross_objcopy -i
> qemu/$container_image -s $source_path --"
> + echo "RANLIB=$docker_py cc --cc $container_cross_ranlib -i
> qemu/$container_image -s $source_path --"
> + echo "STRIP=$docker_py cc --cc $container_cross_strip -i
> qemu/$container_image -s $source_path --"
> + else
> + if test -n "$target_cc"; then
> + echo "CC=$target_cc"
> + echo "CCAS=$target_ccas"
> + fi
> + if test -n "$target_ar"; then
> + echo "AR=$target_ar"
> + fi
> + if test -n "$target_as"; then
> + echo "AS=$target_as"
> + fi
> + if test -n "$target_ld"; then
> + echo "LD=$target_ld"
> + fi
> + if test -n "$target_nm"; then
> + echo "NM=$target_nm"
> + fi
> + if test -n "$target_objcopy"; then
> + echo "OBJCOPY=$target_objcopy"
> + fi
> + if test -n "$target_ranlib"; then
> + echo "RANLIB=$target_ranlib"
> + fi
> + if test -n "$target_strip"; then
> + echo "STRIP=$target_strip"
> + fi
> fi
> - echo "AR=$docker_py cc --cc $container_cross_ar -i qemu/$container_image
> -s $source_path --"
> - echo "AS=$docker_py cc --cc $container_cross_as -i qemu/$container_image
> -s $source_path --"
> - echo "LD=$docker_py cc --cc $container_cross_ld -i qemu/$container_image
> -s $source_path --"
> - echo "NM=$docker_py cc --cc $container_cross_nm -i qemu/$container_image
> -s $source_path --"
> - echo "OBJCOPY=$docker_py cc --cc $container_cross_objcopy -i
> qemu/$container_image -s $source_path --"
> - echo "RANLIB=$docker_py cc --cc $container_cross_ranlib -i
> qemu/$container_image -s $source_path --"
> - echo "STRIP=$docker_py cc --cc $container_cross_strip -i
> qemu/$container_image -s $source_path --"
> }
>
> -
> -
> ##########################################
> # check for vfio_user_server
>
> @@ -2560,15 +2558,9 @@ for target in $target_list; do
> ;;
> esac
>
> - probe_target_compiler $target
> - if test $got_cross_cc = yes; then
> - write_target_makefile >> "$config_target_mak"
> - elif test -n "$container_image"; then
> - build_static=y
> - write_container_target_makefile build-tcg-tests-$target >>
> "$config_target_mak"
> - got_cross_cc=yes
> - fi
> - if test $got_cross_cc = yes; then
> + if probe_target_compiler $target || test -n "$container_image"; then
> + test -n "$container_image" && build_static=y
> + write_target_makefile "build-tcg-tests-$target >> "$config_target_mak"
> mkdir -p "tests/tcg/$target"
> ln -sf "$source_path/tests/tcg/Makefile.target"
> "tests/tcg/$target/Makefile"
> ln -sf "../config-$target.mak" "tests/tcg/$target/config-target.mak"
> --
> 2.34.1
>
signature.asc
Description: PGP signature
- [PULL 14/54] pc-bios/s390-ccw: detect CC options just once, (continued)
- [PULL 14/54] pc-bios/s390-ccw: detect CC options just once, Alex Bennée, 2022/10/04
- [PULL 51/54] contrib/gitdm: add China Telecom to the domain map, Alex Bennée, 2022/10/04
- [PULL 16/54] build: add recursive distclean rules, Alex Bennée, 2022/10/04
- [PULL 35/54] plugins: extend execlog to filter matches, Alex Bennée, 2022/10/04
- [PULL 17/54] configure: return status code from probe_target_compiler, Alex Bennée, 2022/10/04
- [PULL 25/54] configure: move tests/tcg/Makefile.prereqs to root build directory, Alex Bennée, 2022/10/04
- [PULL 44/54] gdbstub: move breakpoint logic to accel ops, Alex Bennée, 2022/10/04
- [PULL 38/54] docs/devel: move API to end of tcg-plugins.rst, Alex Bennée, 2022/10/04
- [PULL 45/54] gdbstub: move guest debug support check to ops, Alex Bennée, 2022/10/04
- [PULL 26/54] configure: unify creation of cross-compilation Makefiles, Alex Bennée, 2022/10/04
- Re: [PULL 26/54] configure: unify creation of cross-compilation Makefiles,
Stefan Hajnoczi <=
- [PULL 53/54] contrib/gitdm: add Université Grenoble Alpes, Alex Bennée, 2022/10/04
- [PULL 36/54] plugins: Assert mmu_idx in range before use in qemu_plugin_get_hwaddr, Alex Bennée, 2022/10/04
- [PULL 19/54] tests: simplify Makefile invocation for tests/tcg, Alex Bennée, 2022/10/04
- [PULL 34/54] disas: use result of ->read_memory_func, Alex Bennée, 2022/10/04
- [PULL 50/54] contrib/gitdm: add ISCAS to the academics group, Alex Bennée, 2022/10/04
- [PULL 33/54] disas: generalise plugin_printf and use for monitor_disas, Alex Bennée, 2022/10/04
- [PULL 49/54] contrib/gitdm: add WANG Xuerui to individual contributers, Alex Bennée, 2022/10/04
- [PULL 40/54] docs/devel: document the test plugins, Alex Bennée, 2022/10/04
- [PULL 42/54] gdbstub: move into its own sub directory, Alex Bennée, 2022/10/04
- [PULL 15/54] vof: add distclean target, Alex Bennée, 2022/10/04