[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] error handling: Use TFR() macro where applicable
From: |
Peter Maydell |
Subject: |
Re: [PATCH] error handling: Use TFR() macro where applicable |
Date: |
Mon, 10 Oct 2022 10:56:14 +0100 |
On Mon, 10 Oct 2022 at 09:34, Nikita Ivanov <nivanov@cloudlinux.com> wrote:
>
> Hi! Thanks for your notes. I'll try to send updated patches by the end of the
> day.
>
> On Fri, Oct 7, 2022 at 6:32 PM Peter Maydell <peter.maydell@linaro.org> wrote:
>> I'm not sure why you've put the TEMP_FAILURE_RETRY on the outside here
>> rather than just on the individual function calls.
>
>
> The original code contained both branches in one while loop, so I was afraid
> that
> value `aiocb->aio_type & QEMU_AIO_WRITE` would change somehow during the loop.
> If you'll say that this is impossible, I'll adjust the code as you propose.
Oh, yes, I see. No, nothing should be changing that during the loop,
I think it's just written the way it is now because it seemed neater
when you write out the retry longhand.
-- PMM