[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v11 08/17] net: stream: Don't ignore EINVAL on netdev socket conn
From: |
Laurent Vivier |
Subject: |
[PATCH v11 08/17] net: stream: Don't ignore EINVAL on netdev socket connection |
Date: |
Tue, 11 Oct 2022 22:05:30 +0200 |
From: Stefano Brivio <sbrivio@redhat.com>
Other errors are treated as failure by net_stream_client_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.
Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
[lvivier: applied to net/stream.c]
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
---
net/stream.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/stream.c b/net/stream.c
index 37965eb74e1a..26e485438718 100644
--- a/net/stream.c
+++ b/net/stream.c
@@ -360,8 +360,7 @@ static int net_stream_client_init(NetClientState *peer,
if (errno == EINTR || errno == EWOULDBLOCK) {
/* continue */
} else if (errno == EINPROGRESS ||
- errno == EALREADY ||
- errno == EINVAL) {
+ errno == EALREADY) {
break;
} else {
error_setg_errno(errp, errno, "can't connect socket");
--
2.37.3
- [PATCH v11 00/17] qapi: net: add unix socket type support to netdev backend, Laurent Vivier, 2022/10/11
- [PATCH v11 11/17] net: dgram: move mcast specific code from net_socket_fd_init_dgram(), Laurent Vivier, 2022/10/11
- [PATCH v11 13/17] qemu-sockets: move and rename SocketAddress_to_str(), Laurent Vivier, 2022/10/11
- [PATCH v11 04/17] qapi: net: introduce a way to bypass qemu_opts_parse_noisily(), Laurent Vivier, 2022/10/11
- [PATCH v11 02/17] net: remove the @errp argument of net_client_inits(), Laurent Vivier, 2022/10/11
- [PATCH v11 03/17] net: simplify net_client_parse() error management, Laurent Vivier, 2022/10/11
- [PATCH v11 01/17] net: introduce convert_host_port(), Laurent Vivier, 2022/10/11
- [PATCH v11 05/17] net: introduce qemu_set_info_str() function, Laurent Vivier, 2022/10/11
- [PATCH v11 07/17] net: socket: Don't ignore EINVAL on netdev socket connection, Laurent Vivier, 2022/10/11
- [PATCH v11 08/17] net: stream: Don't ignore EINVAL on netdev socket connection,
Laurent Vivier <=
- [PATCH v11 06/17] qapi: net: add stream and dgram netdevs, Laurent Vivier, 2022/10/11
- [PATCH v11 09/17] net: stream: add unix socket, Laurent Vivier, 2022/10/11
- [PATCH v11 10/17] net: dgram: make dgram_dst generic, Laurent Vivier, 2022/10/11
- [PATCH v11 14/17] qemu-sockets: update socket_uri() and socket_parse() to be consistent, Laurent Vivier, 2022/10/11
- [PATCH v11 15/17] net: stream: move to QIO to enable additional parameters, Laurent Vivier, 2022/10/11
- [PATCH v11 16/17] tests/qtest: netdev: test stream and dgram backends, Laurent Vivier, 2022/10/11
- [PATCH v11 17/17] net: stream: add QAPI events to report connection state, Laurent Vivier, 2022/10/11