Re: [PATCH v6 07/10] acpi/tests/avocado/bits: add biosbits config file for running bios tests

[Ani Sinha]

On Thu, Oct 20, 2022 at 11:18 PM Alex Bennée <alex.bennee@linaro.org> wrote:
>
>
> Ani Sinha <ani@anisinha.ca> writes:
>
> > This change adds initial biosbits config file that instructs biosbits to run
> > bios test suits in batch mode. Additionally acpi and smbios structures are 
> > also
> > dumped.
>
> Is it possible to split this into different avocado tests or would it
> require building multiple isos?

Bits takes this configuration to decide which tests it should run.
Currently, this config is not modified from the original bits config
file upstream.
It might be possible to use different config files for different bits
tests as you suggested and generate a separate iso for each of the
tests with their corresponding config file (and then use that iso for
the corresponding test).
However, I would like to leave this as a future exercise. Currently,
it's simple enough in my opinion to have just one config file and run
all the tests in batch mode. I do not see a compelling reason to add
the extra complication of generating an iso for every sub-test yet.

>
> Otherwise:
>
> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>
>
> >
> > Cc: Daniel P. Berrangé <berrange@redhat.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Maydell Peter <peter.maydell@linaro.org>
> > Cc: John Snow <jsnow@redhat.com>
> > Cc: Thomas Huth <thuth@redhat.com>
> > Cc: Alex Bennée <alex.bennee@linaro.org>
> > Cc: Igor Mammedov <imammedo@redhat.com>
> > Cc: Michael Tsirkin <mst@redhat.com>
> > Signed-off-by: Ani Sinha <ani@anisinha.ca>
> > ---
> >  .../avocado/acpi-bits/bits-config/bits-cfg.txt | 18 ++++++++++++++++++
> >  1 file changed, 18 insertions(+)
> >  create mode 100644 tests/avocado/acpi-bits/bits-config/bits-cfg.txt
> >
> > diff --git a/tests/avocado/acpi-bits/bits-config/bits-cfg.txt
> > b/tests/avocado/acpi-bits/bits-config/bits-cfg.txt
> > new file mode 100644
> > index 0000000000..8010804453
> > --- /dev/null
> > +++ b/tests/avocado/acpi-bits/bits-config/bits-cfg.txt
> > @@ -0,0 +1,18 @@
> > +# BITS configuration file
> > +[bits]
> > +
> > +# To run BITS in batch mode, set batch to a list of one or more of the
> > +# following keywords; BITS will then run all of the requested operations, 
> > then
> > +# save the log file to disk.
> > +#
> > +# test: Run the full BITS testsuite.
> > +# acpi: Dump all ACPI structures.
> > +# smbios: Dump all SMBIOS structures.
> > +#
> > +# Leave batch set to an empty string to disable batch mode.
> > +# batch =
> > +
> > +# Uncomment the following to run all available batch operations
> > +# please take a look at boot/python/init.py in bits zip file
> > +# to see how these options are parsed and used.
> > +batch = test acpi smbios
>
>
> --
> Alex Bennée