[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/11] kset: fix documentation for kset_register()
From: |
Greg KH |
Subject: |
Re: [PATCH 01/11] kset: fix documentation for kset_register() |
Date: |
Fri, 21 Oct 2022 10:16:26 +0200 |
On Fri, Oct 21, 2022 at 04:05:18PM +0800, Yang Yingliang wrote:
>
> On 2022/10/21 13:34, Luben Tuikov wrote:
> > On 2022-10-20 22:20, Yang Yingliang wrote:
> > > kset_register() is currently used in some places without calling
> > > kset_put() in error path, because the callers think it should be
> > > kset internal thing to do, but the driver core can not know what
> > > caller doing with that memory at times. The memory could be freed
> > > both in kset_put() and error path of caller, if it is called in
> > > kset_register().
> > >
> > > So make the function documentation more explicit about calling
> > > kset_put() in the error path of caller.
> > >
> > > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > > ---
> > > lib/kobject.c | 3 +++
> > > 1 file changed, 3 insertions(+)
> > >
> > > diff --git a/lib/kobject.c b/lib/kobject.c
> > > index a0b2dbfcfa23..6da04353d974 100644
> > > --- a/lib/kobject.c
> > > +++ b/lib/kobject.c
> > > @@ -834,6 +834,9 @@ EXPORT_SYMBOL_GPL(kobj_sysfs_ops);
> > > /**
> > > * kset_register() - Initialize and add a kset.
> > > * @k: kset.
> > > + *
> > > + * If this function returns an error, kset_put() must be called to
> > > + * properly clean up the memory associated with the object.
> > > */
> > And I'd continue the sentence, with " ... with the object,
> > for instance the memory for the kset.kobj.name when
> > kobj_set_name(&kset.kobj, format, ...)
> > was called before calling kset_register()."
> kobject_cleanup() not only frees name, but aslo calls ->release() to free
> another resources.
Yes, but it's the kobject of the kset, which does need to have it's name
cleaned up, but that kobject should NOT be freeing any larger structures
that the kset might be embedded in, right?
> > This makes it clear what we want to make sure is freed, in case of an early
> > error
> > from kset_register().
>
> How about like this:
>
> If this function returns an error, kset_put() must be called to clean up the
> name of
> kset object and other memory associated with the object.
Again, I think we can fix this up to not be needed.
thanks,
greg k-h
- [PATCH 00/11] fix memory leak while kset_register() fails, Yang Yingliang, 2022/10/20
- [PATCH 02/11] kset: add null pointer check in kset_put(), Yang Yingliang, 2022/10/20
- [PATCH 10/11] drm/amdgpu/discovery: fix possible memory leak, Yang Yingliang, 2022/10/20
- [PATCH 07/11] f2fs: fix possible memory leak in f2fs_init_sysfs(), Yang Yingliang, 2022/10/20
- [PATCH 11/11] ubifs: Fix memory leak in ubifs_sysfs_init(), Yang Yingliang, 2022/10/20
- [PATCH 06/11] firmware: qemu_fw_cfg: fix possible memory leak in fw_cfg_build_symlink(), Yang Yingliang, 2022/10/20
- [PATCH 01/11] kset: fix documentation for kset_register(), Yang Yingliang, 2022/10/20
- [PATCH 04/11] kobject: fix possible memory leak in kset_create_and_add(), Yang Yingliang, 2022/10/20
- [PATCH 08/11] erofs: fix possible memory leak in erofs_init_sysfs(), Yang Yingliang, 2022/10/20
- [PATCH 03/11] bus: fix possible memory leak in bus_register(), Yang Yingliang, 2022/10/20
- [PATCH 05/11] class: fix possible memory leak in __class_register(), Yang Yingliang, 2022/10/20
- [PATCH 09/11] ocfs2: possible memory leak in mlog_sys_init(), Yang Yingliang, 2022/10/20
- Re: [PATCH 00/11] fix memory leak while kset_register() fails, Luben Tuikov, 2022/10/21