[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 24/31] target/s390x: don't use ld_code2 to probe next pc
From: |
Alex Bennée |
Subject: |
[PULL 24/31] target/s390x: don't use ld_code2 to probe next pc |
Date: |
Mon, 31 Oct 2022 13:10:03 +0000 |
This isn't an translator picking up an instruction so we shouldn't use
the translator_lduw function which has side effects for plugins.
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Acked-by: Ilya Leoshkevich <iii@linux.ibm.com>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20221027183637.2772968-24-alex.bennee@linaro.org>
diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
index 5798928473..9df7f9e693 100644
--- a/target/s390x/tcg/translate.c
+++ b/target/s390x/tcg/translate.c
@@ -6612,7 +6612,7 @@ static void s390x_tr_insn_start(DisasContextBase *dcbase,
CPUState *cs)
static target_ulong get_next_pc(CPUS390XState *env, DisasContext *s,
uint64_t pc)
{
- uint64_t insn = ld_code2(env, s, pc);
+ uint64_t insn = cpu_lduw_code(env, pc);
return pc + get_ilen((insn >> 8) & 0xff);
}
--
2.34.1
- [PULL 01/31] tests/lcitool: Rename non-Debian specific helper, (continued)
- [PULL 01/31] tests/lcitool: Rename non-Debian specific helper, Alex Bennée, 2022/10/31
- [PULL 05/31] tests/docker: Add flex/bison to `debian-all-test`, Alex Bennée, 2022/10/31
- [PULL 02/31] tests/lcitool: Refresh to latest libvirt-ci module, Alex Bennée, 2022/10/31
- [PULL 08/31] tests/avocado: extend the timeout for x86_64 tcg tests, Alex Bennée, 2022/10/31
- [PULL 26/31] target/s390x: fake instruction loading when handling 'ex', Alex Bennée, 2022/10/31
- [PULL 25/31] target/s390x: don't probe next pc for EXecuted insns, Alex Bennée, 2022/10/31
- [PULL 28/31] contrib/plugins: enable debug on CONFIG_DEBUG_TCG, Alex Bennée, 2022/10/31
- [PULL 19/31] tests/avocado: set -machine none for userfwd and vnc tests, Alex Bennée, 2022/10/31
- [PULL 17/31] MAINTAINERS: add features_to_c.sh to gdbstub files, Alex Bennée, 2022/10/31
- [PULL 30/31] tests/unit: cleanups for test-io-channel-command, Alex Bennée, 2022/10/31
- [PULL 24/31] target/s390x: don't use ld_code2 to probe next pc,
Alex Bennée <=
- [PULL 20/31] tests/avocado: raspi2_initrd: Wait for guest shutdown message before stopping, Alex Bennée, 2022/10/31
- [PULL 21/31] tests/avocado: disable sh4 rd2 tests on Gitlab, Alex Bennée, 2022/10/31
- [PULL 23/31] tests/tcg: re-enable threadcount for sh4, Alex Bennée, 2022/10/31
- [PULL 31/31] tests/vm: use -o IdentitiesOnly=yes for ssh, Alex Bennée, 2022/10/31
- [PULL 22/31] tests/tcg: re-enable linux-test for sh4, Alex Bennée, 2022/10/31
- [PULL 29/31] contrib/plugins: protect execlog's last_exec expansion, Alex Bennée, 2022/10/31
- [PULL 18/31] MAINTAINERS: fix-up for check-tcg Makefile changes, Alex Bennée, 2022/10/31
- [PULL 27/31] tests/tcg: include CONFIG_PLUGIN in config-host.mak, Alex Bennée, 2022/10/31
- [PULL 16/31] MAINTAINERS: add entries for the key build bits, Alex Bennée, 2022/10/31
- Re: [PULL for 7.2 00/31] testing and plugins updates, Stefan Hajnoczi, 2022/10/31