qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 14/20] hw/audio: explicitly set .requester_type for intel-


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v5 14/20] hw/audio: explicitly set .requester_type for intel-hda
Date: Sun, 13 Nov 2022 20:50:06 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.4.2

On 12/11/22 06:50, Richard Henderson wrote:
On 11/12/22 04:25, Alex Bennée wrote:
This is simulating a bus master writing data back into system memory.
Mark it as such.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
  hw/audio/intel-hda.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c
index f38117057b..95c28b315c 100644
--- a/hw/audio/intel-hda.c
+++ b/hw/audio/intel-hda.c
@@ -345,7 +345,7 @@ static void intel_hda_corb_run(IntelHDAState *d)
  static void intel_hda_response(HDACodecDevice *dev, bool solicited, uint32_t response)
  {
-    const MemTxAttrs attrs = { .memory = true };
+    const MemTxAttrs attrs = { .requester_type = MTRT_PCI, .memory = true };

MEMTXATTRS_PCI?

Then removing the 'const' qualifier and setting .memory after.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]