[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 1/1] migration: Fix yank on postcopy multifd crashing gues
From: |
Peter Xu |
Subject: |
Re: [PATCH v1 1/1] migration: Fix yank on postcopy multifd crashing guest after migration |
Date: |
Thu, 24 Nov 2022 11:04:42 -0500 |
On Wed, Nov 09, 2022 at 02:56:29AM -0300, Leonardo Bras wrote:
> diff --git a/migration/savevm.c b/migration/savevm.c
> index a0cdb714f7..250caff7f4 100644
> --- a/migration/savevm.c
> +++ b/migration/savevm.c
> @@ -1889,6 +1889,8 @@ static void *postcopy_ram_listen_thread(void *opaque)
> exit(EXIT_FAILURE);
> }
>
> + migration_load_cleanup();
It's a bit weird to call multifd-load-clean in a listen phase..
How about moving it right above
trace_process_incoming_migration_co_postcopy_end_main()? Then the new
helper can also be static.
> +
> migrate_set_state(&mis->state, MIGRATION_STATUS_POSTCOPY_ACTIVE,
> MIGRATION_STATUS_COMPLETED);
> /*
> --
> 2.38.1
>
--
Peter Xu