[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI
|
From: |
Michael S. Tsirkin |
|
Subject: |
Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI |
|
Date: |
Mon, 28 Nov 2022 05:26:24 -0500 |
On Mon, Nov 28, 2022 at 11:21:36AM +0100, Markus Armbruster wrote:
> Philippe Mathieu-Daudé <philmd@linaro.org> writes:
>
> > On 28/11/22 09:01, Markus Armbruster wrote:
> >> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when
> >> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when
> >> !CONFIG_PCI. Build pci-hmp-cmds.c that way, too.
> >> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> >> ---
> >> hw/pci/pci-stub.c | 5 +++++
> >> hw/pci/meson.build | 2 +-
> >> 2 files changed, 6 insertions(+), 1 deletion(-)
> >
> > Squash with patch #3?
>
> Could do, but the combined patch isn't pure code motion anymore, and I
> get to explain that in the commit message.
Yes I like it the way it is.
--
MST
- [PATCH 02/12] pci: Move QMP commands to new hw/pci/pci-qmp-cmds.c, (continued)
- [PATCH 02/12] pci: Move QMP commands to new hw/pci/pci-qmp-cmds.c, Markus Armbruster, 2022/11/28
- [PATCH 04/12] pci: Make query-pci stub consistent with the real one, Markus Armbruster, 2022/11/28
- [PATCH 06/12] pci: Deduplicate get_class_desc(), Markus Armbruster, 2022/11/28
- [PATCH 09/12] pci: Move HMP command from hw/pci/pcie_aer.c to pci-hmp-cmds.c, Markus Armbruster, 2022/11/28
- [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI, Markus Armbruster, 2022/11/28
- Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI, Dr. David Alan Gilbert, 2022/11/28
Re: [PATCH 00/12] pci: Move and clean up monitor command code, Michael S. Tsirkin, 2022/11/28
Re: [PATCH 00/12] pci: Move and clean up monitor command code, Michael S. Tsirkin, 2022/11/28