|
From: | Richard Henderson |
Subject: | Re: [PATCH RFC v2 6/9] target/loongarch: Implement kvm_arch_init_vcpu |
Date: | Tue, 2 May 2023 12:32:01 +0100 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 |
On 4/27/23 08:26, Tianrui Zhao wrote:
+static void kvm_loongarch_vm_stage_change(void *opaque, bool running,
Typo: state
+ uint64_t counter_value;
I know naming is hard, but this is so generic it is difficult to determine what it does. Perhaps kvm_state_counter? A comment would also be helpful, even with a renaming.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |