Re: [PATCH v20 01/21] s390x/cpu topology: add s390 specifics to CPU topology

[Pierre Morel]

On 4/27/23 10:04, Thomas Huth wrote:
> On 25/04/2023 18.14, Pierre Morel wrote:
> > S390 adds two new SMP levels, drawers and books to the CPU
> > topology.
> > The S390 CPU have specific topology features like dedication
> > and entitlement to give to the guest indications on the host
> > vCPUs scheduling and help the guest take the best decisions
> > on the scheduling of threads on the vCPUs.
> >
> > Let us provide the SMP properties with books and drawers levels
> > and S390 CPU with dedication and entitlement,
> >
> > Signed-off-by: Pierre Morel <pmorel@linux.ibm.com>
> > ---
> ...> diff --git a/qapi/machine-target.json b/qapi/machine-target.json
> > index 2e267fa458..42a6a40333 100644
> > --- a/qapi/machine-target.json
> > +++ b/qapi/machine-target.json
> > @@ -342,3 +342,15 @@
> >                      'TARGET_S390X',
> >                      'TARGET_MIPS',
> >                      'TARGET_LOONGARCH64' ] } }
> > +
> > +##
> > +# @CpuS390Polarization:
> > +#
> > +# An enumeration of cpu polarization that can be assumed by a virtual
> > +# S390 CPU
> > +#
> > +# Since: 8.1
> > +##
> > +{ 'enum': 'CpuS390Polarization',
> > +  'prefix': 'S390_CPU_POLARIZATION',
> > +  'data': [ 'horizontal', 'vertical' ] }
>
> It seems like you don't need this here yet ... I think you likely 
> could also introduce it in a later patch instead (patch 11 seems the 
> first one that needs this?)

patch 6 on PTF interception in fact but yes you are right and I will 
shift it there.


> Also, would a " 'if': 'TARGET_S390X' " be possible here, too?


yes.

Regards,

Pierre