[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 15/44] Hexagon (target/hexagon) Remove log_reg_write from op_helpe
From: |
Taylor Simpson |
Subject: |
[PULL 15/44] Hexagon (target/hexagon) Remove log_reg_write from op_helper.[ch] |
Date: |
Fri, 12 May 2023 14:46:37 -0700 |
With the overrides added in prior commits, this function is not used
Remove references in macros.h
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230427230012.3800327-7-tsimpson@quicinc.com>
---
target/hexagon/macros.h | 14 --------------
target/hexagon/op_helper.h | 4 ----
target/hexagon/op_helper.c | 17 -----------------
3 files changed, 35 deletions(-)
diff --git a/target/hexagon/macros.h b/target/hexagon/macros.h
index b1ff40c894..995ae0e384 100644
--- a/target/hexagon/macros.h
+++ b/target/hexagon/macros.h
@@ -343,10 +343,6 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val,
int shift)
#define fREAD_LR() (env->gpr[HEX_REG_LR])
-#define fWRITE_LR(A) log_reg_write(env, HEX_REG_LR, A)
-#define fWRITE_FP(A) log_reg_write(env, HEX_REG_FP, A)
-#define fWRITE_SP(A) log_reg_write(env, HEX_REG_SP, A)
-
#define fREAD_SP() (env->gpr[HEX_REG_SP])
#define fREAD_LC0 (env->gpr[HEX_REG_LC0])
#define fREAD_LC1 (env->gpr[HEX_REG_LC1])
@@ -371,16 +367,6 @@ static inline TCGv gen_read_ireg(TCGv result, TCGv val,
int shift)
#define fBRANCH(LOC, TYPE) fWRITE_NPC(LOC)
#define fJUMPR(REGNO, TARGET, TYPE) fBRANCH(TARGET, COF_TYPE_JUMPR)
#define fHINTJR(TARGET) { /* Not modelled in qemu */}
-#define fWRITE_LOOP_REGS0(START, COUNT) \
- do { \
- log_reg_write(env, HEX_REG_LC0, COUNT); \
- log_reg_write(env, HEX_REG_SA0, START); \
- } while (0)
-#define fWRITE_LOOP_REGS1(START, COUNT) \
- do { \
- log_reg_write(env, HEX_REG_LC1, COUNT); \
- log_reg_write(env, HEX_REG_SA1, START);\
- } while (0)
#define fSET_OVERFLOW() SET_USR_FIELD(USR_OVF, 1)
#define fSET_LPCFG(VAL) SET_USR_FIELD(USR_LPCFG, (VAL))
diff --git a/target/hexagon/op_helper.h b/target/hexagon/op_helper.h
index db22b54401..6bd4b07849 100644
--- a/target/hexagon/op_helper.h
+++ b/target/hexagon/op_helper.h
@@ -19,15 +19,11 @@
#define HEXAGON_OP_HELPER_H
/* Misc functions */
-void write_new_pc(CPUHexagonState *env, bool pkt_has_multi_cof, target_ulong
addr);
-
uint8_t mem_load1(CPUHexagonState *env, uint32_t slot, target_ulong vaddr);
uint16_t mem_load2(CPUHexagonState *env, uint32_t slot, target_ulong vaddr);
uint32_t mem_load4(CPUHexagonState *env, uint32_t slot, target_ulong vaddr);
uint64_t mem_load8(CPUHexagonState *env, uint32_t slot, target_ulong vaddr);
-void log_reg_write(CPUHexagonState *env, int rnum,
- target_ulong val);
void log_store64(CPUHexagonState *env, target_ulong addr,
int64_t val, int width, int slot);
void log_store32(CPUHexagonState *env, target_ulong addr,
diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c
index 3cc71b69d9..7e9e3f305e 100644
--- a/target/hexagon/op_helper.c
+++ b/target/hexagon/op_helper.c
@@ -52,23 +52,6 @@ G_NORETURN void HELPER(raise_exception)(CPUHexagonState
*env, uint32_t excp)
do_raise_exception_err(env, excp, 0);
}
-void log_reg_write(CPUHexagonState *env, int rnum,
- target_ulong val)
-{
- HEX_DEBUG_LOG("log_reg_write[%d] = " TARGET_FMT_ld " (0x" TARGET_FMT_lx
")",
- rnum, val, val);
- if (val == env->gpr[rnum]) {
- HEX_DEBUG_LOG(" NO CHANGE");
- }
- HEX_DEBUG_LOG("\n");
-
- env->new_value[rnum] = val;
- if (HEX_DEBUG) {
- /* Do this so HELPER(debug_commit_end) will know */
- env->reg_written[rnum] = 1;
- }
-}
-
static void log_pred_write(CPUHexagonState *env, int pnum, target_ulong val)
{
HEX_DEBUG_LOG("log_pred_write[%d] = " TARGET_FMT_ld
--
2.25.1
- [PULL 35/44] Hexagon: append eflags to unknown cpu model string, (continued)
- [PULL 35/44] Hexagon: append eflags to unknown cpu model string, Taylor Simpson, 2023/05/12
- [PULL 16/44] Hexagon (target/hexagon) Eliminate uses of log_pred_write function, Taylor Simpson, 2023/05/12
- [PULL 31/44] Hexagon (target/hexagon) Additional instructions handled by idef-parser, Taylor Simpson, 2023/05/12
- [PULL 04/44] Hexagon (target/hexagon) Add v68 HVX instructions, Taylor Simpson, 2023/05/12
- [PULL 24/44] Hexagon (target/hexagon) Add overrides for disabled idef-parser insns, Taylor Simpson, 2023/05/12
- [PULL 21/44] Hexagon (target/hexagon) Short-circuit packet predicate writes, Taylor Simpson, 2023/05/12
- [PULL 11/44] Hexagon (target/hexagon) Add DisasContext arg to gen_log_reg_write, Taylor Simpson, 2023/05/12
- [PULL 28/44] Hexagon (target/hexagon) Move pred_written to DisasContext, Taylor Simpson, 2023/05/12
- [PULL 27/44] Hexagon (target/hexagon) Move new_pred_value to DisasContext, Taylor Simpson, 2023/05/12
- [PULL 34/44] Hexagon: list available CPUs with `-cpu help`, Taylor Simpson, 2023/05/12
- [PULL 15/44] Hexagon (target/hexagon) Remove log_reg_write from op_helper.[ch],
Taylor Simpson <=
- [PULL 25/44] Hexagon (target/hexagon) Make special new_value for USR, Taylor Simpson, 2023/05/12
- [PULL 18/44] Hexagon (target/hexagon) Don't overlap dest writes with source reads, Taylor Simpson, 2023/05/12
- [PULL 26/44] Hexagon (target/hexagon) Move new_value to DisasContext, Taylor Simpson, 2023/05/12
- [PULL 10/44] meson.build Add CONFIG_HEXAGON_IDEF_PARSER, Taylor Simpson, 2023/05/12
- [PULL 19/44] Hexagon (target/hexagon) Mark registers as read during packet analysis, Taylor Simpson, 2023/05/12
- [PULL 20/44] Hexagon (target/hexagon) Short-circuit packet register writes, Taylor Simpson, 2023/05/12
- [PULL 29/44] Hexagon (target/hexagon) Move pkt_has_store_s1 to DisasContext, Taylor Simpson, 2023/05/12
- [PULL 44/44] Hexagon (linux-user/hexagon): handle breakpoints, Taylor Simpson, 2023/05/12
- [PULL 40/44] gdbstub: add test for untimely stop-reply packets, Taylor Simpson, 2023/05/12
- [PULL 42/44] Hexagon (gdbstub): fix p3:0 read and write via stub, Taylor Simpson, 2023/05/12