[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/6] ebpf: Updated eBPF program and skeleton.
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 6/6] ebpf: Updated eBPF program and skeleton. |
Date: |
Tue, 16 May 2023 16:29:18 -0500 |
User-agent: |
NeoMutt/20230512 |
On Fri, May 12, 2023 at 03:29:02PM +0300, Andrew Melnychenko wrote:
>
> Updated section name, so libbpf should init/gues proper
> program type without specifications during open/load.
>
> Signed-off-by: Andrew Melnychenko <andrew@daynix.com>
> ---
> ebpf/rss.bpf.skeleton.h | 1469 ++++++++++++++++++++-------------------
> tools/ebpf/rss.bpf.c | 2 +-
> 2 files changed, 741 insertions(+), 730 deletions(-)
>
> diff --git a/ebpf/rss.bpf.skeleton.h b/ebpf/rss.bpf.skeleton.h
> index 18eb2adb12c..41b84aea44c 100644
> --- a/ebpf/rss.bpf.skeleton.h
> +++ b/ebpf/rss.bpf.skeleton.h
> @@ -176,162 +176,162 @@ err:
>
> static inline const void *rss_bpf__elf_bytes(size_t *sz)
> {
> - *sz = 20440;
> + *sz = 20720;
> return (const void *)"\
>
> \x7f\x45\x4c\x46\x02\x01\x01\0\0\0\0\0\0\0\0\0\x01\0\xf7\0\x01\0\0\0\0\0\0\0\0\
> -\0\0\0\0\0\0\0\0\0\0\0\x98\x4c\0\0\0\0\0\0\0\0\0\0\x40\0\0\0\0\0\x40\0\x0d\0\
Appears to be pre-existing, and looking at the broader context, I see
this comment earlier in the file:
/* SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) */
/* THIS FILE IS AUTOGENERATED BY BPFTOOL! */
but a suggestion to improve things: tweak the comment produced by the
generator to also output the name of the source file (not just the
bpftool generator), to make it easier to figure out how to map this
binary blob of data back to human-readable source and instructions on
how to regenerate it should I want to edit those sources.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v2 0/6] eBPF RSS through QMP support., Andrew Melnychenko, 2023/05/12
- [PATCH v2 1/6] ebpf: Added eBPF map update through mmap., Andrew Melnychenko, 2023/05/12
- [PATCH v2 6/6] ebpf: Updated eBPF program and skeleton., Andrew Melnychenko, 2023/05/12
- [PATCH v2 3/6] virtio-net: Added property to load eBPF RSS with fds., Andrew Melnychenko, 2023/05/12
- [PATCH v2 2/6] ebpf: Added eBPF initialization by fds., Andrew Melnychenko, 2023/05/12
- [PATCH v2 5/6] qmp: Added new command to retrieve eBPF blob., Andrew Melnychenko, 2023/05/12