Re: [PATCH] [rpi4b] Make bootable rpi4b model

[Peter Maydell]

On Mon, 22 May 2023 at 11:29, Sergey Kambalin <serg.oker@gmail.com> wrote:
>
> Signed-off-by: Sergey Kambalin <sergey.kambalin@auriga.com>
> ---
>  configs/devices/aarch64-softmmu/default.mak |   2 +
>  hw/arm/Kconfig                              |   7 +
>  hw/arm/bcm2835_peripherals.c                | 223 ++++++-----
>  hw/arm/bcm2836.c                            | 129 ++++---
>  hw/arm/bcm2838.c                            | 283 ++++++++++++++
>  hw/arm/bcm2838_peripherals.c                | 213 +++++++++++
>  hw/arm/meson.build                          |   5 +
>  hw/arm/raspi.c                              | 129 ++++---
>  hw/arm/raspi4b.c                            | 243 ++++++++++++
>  hw/arm/trace-events                         |   2 +
>  hw/gpio/bcm2838_gpio.c                      | 395 ++++++++++++++++++++
>  hw/gpio/meson.build                         |   1 +
>  hw/misc/bcm2835_powermgt.c                  |  37 ++
>  hw/misc/bcm2835_property.c                  | 318 +++++++++++++---
>  hw/misc/trace-events                        |  10 +
>  include/hw/arm/bcm2835_peripherals.h        |  29 +-
>  include/hw/arm/bcm2836.h                    |  30 +-
>  include/hw/arm/bcm2838.h                    |  26 ++
>  include/hw/arm/bcm2838_peripherals.h        |  50 +++
>  include/hw/arm/raspi4b_platform.h           |  58 +++
>  include/hw/arm/raspi_platform.h             |  34 ++
>  include/hw/display/bcm2835_fb.h             |   2 +
>  include/hw/gpio/bcm2838_gpio.h              |  45 +++
>  include/hw/misc/bcm2835_powermgt.h          |   2 +-
>  include/hw/misc/raspberrypi-fw-defs.h       | 169 +++++++++
>  tests/avocado/boot_linux_console.py         |  37 ++
>  26 files changed, 2210 insertions(+), 269 deletions(-)

Hi; this is far too large to be reviewable as a single patch.
It must be split into more digestible chunks (each of which
does a single reasonably coherent thing) before we can
do anything with it.

thanks
-- PMM