Re: [PATCH v2 45/52] tcg: Define IN_TCG

[Richard Henderson]

On 5/23/23 09:45, Philippe Mathieu-Daudé wrote:
> On 23/5/23 15:53, Richard Henderson wrote:
> > Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> > ---
> >   tcg/region.c      | 2 ++
> >   tcg/tcg-common.c  | 2 ++
> >   tcg/tcg-op-gvec.c | 2 ++
> >   tcg/tcg-op-ldst.c | 2 ++
> >   tcg/tcg-op-vec.c  | 2 ++
> >   tcg/tcg-op.c      | 2 ++
> >   tcg/tcg.c         | 2 ++
> >   7 files changed, 14 insertions(+)
> >
> > diff --git a/tcg/region.c b/tcg/region.c
> > index bef4c4756f..34ac124081 100644
> > --- a/tcg/region.c
> > +++ b/tcg/region.c
> > @@ -22,6 +22,8 @@
> >    * THE SOFTWARE.
> >    */
> > +#define IN_TCG
> > +
> >   #include "qemu/osdep.h"
> >   #include "qemu/units.h"
> >   #include "qemu/madvise.h"
> > diff --git a/tcg/tcg-common.c b/tcg/tcg-common.c
> > index 35e7616ae9..678ab482f7 100644
> > --- a/tcg/tcg-common.c
> > +++ b/tcg/tcg-common.c
> > @@ -22,6 +22,8 @@
> >    * THE SOFTWARE.
> >    */
> > +#define IN_TCG
> > +
> >   #include "qemu/osdep.h"
> >   #include "tcg/tcg.h"
>
> [...]
>
> Could this be enforced via meson instead? Smth like:
>
>    static_library(tcgcommon.fa,
>                   [tcgcommon_ss.sources()],
>                   c_args: [-DIN_TCG], ...)

Actually, it's rubbish now.  I think this was meant for exec/poison.h, but I'm not 
currently using it there.

r~