[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 4/5] Hexagon: fix outdated `hex_new_*` comments
From: |
Taylor Simpson |
Subject: |
[PULL 4/5] Hexagon: fix outdated `hex_new_*` comments |
Date: |
Fri, 26 May 2023 07:20:27 -0700 |
From: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Some code comments refer to hex_new_value and hex_new_pred_value, which
have been transferred to DisasContext and, in the case of hex_new_value,
should now be accessed through get_result_gpr().
In order to fix this outdated comments and also avoid having to tweak
them whenever we make a variable name change in the future, let's
replace them with pseudocode.
Suggested-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Matheus Tavares Bernardino <quic_mathbern@quicinc.com>
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id:
<8e1689e28dd7b1318369b55127cf47b82ab75921.1684939078.git.quic_mathbern@quicinc.com>
---
target/hexagon/genptr.c | 26 ++++++++++++--------------
target/hexagon/translate.c | 2 +-
2 files changed, 13 insertions(+), 15 deletions(-)
diff --git a/target/hexagon/genptr.c b/target/hexagon/genptr.c
index cb2aa28a19..bcb287dd8b 100644
--- a/target/hexagon/genptr.c
+++ b/target/hexagon/genptr.c
@@ -878,9 +878,9 @@ static void gen_endloop0(DisasContext *ctx)
*/
if (!ctx->is_tight_loop) {
/*
- * if (hex_gpr[HEX_REG_LC0] > 1) {
- * PC = hex_gpr[HEX_REG_SA0];
- * hex_new_value[HEX_REG_LC0] = hex_gpr[HEX_REG_LC0] - 1;
+ * if (LC0 > 1) {
+ * PC = SA0;
+ * LC0--;
* }
*/
TCGLabel *label3 = gen_new_label();
@@ -897,9 +897,9 @@ static void gen_endloop0(DisasContext *ctx)
static void gen_endloop1(DisasContext *ctx)
{
/*
- * if (hex_gpr[HEX_REG_LC1] > 1) {
- * PC = hex_gpr[HEX_REG_SA1];
- * hex_new_value[HEX_REG_LC1] = hex_gpr[HEX_REG_LC1] - 1;
+ * if (LC1 > 1) {
+ * PC = SA1;
+ * LC1--;
* }
*/
TCGLabel *label = gen_new_label();
@@ -946,14 +946,12 @@ static void gen_endloop01(DisasContext *ctx)
gen_set_label(label2);
/*
- * if (hex_gpr[HEX_REG_LC0] > 1) {
- * PC = hex_gpr[HEX_REG_SA0];
- * hex_new_value[HEX_REG_LC0] = hex_gpr[HEX_REG_LC0] - 1;
- * } else {
- * if (hex_gpr[HEX_REG_LC1] > 1) {
- * hex_next_pc = hex_gpr[HEX_REG_SA1];
- * hex_new_value[HEX_REG_LC1] = hex_gpr[HEX_REG_LC1] - 1;
- * }
+ * if (LC0 > 1) {
+ * PC = SA0;
+ * LC0--;
+ * } else if (LC1 > 1) {
+ * PC = SA1;
+ * LC1--;
* }
*/
tcg_gen_brcondi_tl(TCG_COND_LEU, hex_gpr[HEX_REG_LC0], 1, label3);
diff --git a/target/hexagon/translate.c b/target/hexagon/translate.c
index b18f1a9051..8838ab2364 100644
--- a/target/hexagon/translate.c
+++ b/target/hexagon/translate.c
@@ -556,7 +556,7 @@ static void gen_start_packet(DisasContext *ctx)
}
/*
- * Preload the predicated pred registers into hex_new_pred_value[pred_num]
+ * Preload the predicated pred registers into ctx->new_pred_value[pred_num]
* Only endloop instructions conditionally write to pred registers
*/
if (ctx->need_commit && pkt->pkt_has_endloop) {
--
2.25.1
- [PULL 0/5] Hexagon update, Taylor Simpson, 2023/05/26
- [PULL 3/5] target/hexagon/*.py: clean up used 'toss' and 'numregs' vars, Taylor Simpson, 2023/05/26
- [PULL 5/5] Hexagon (target/hexagon) Change Hexagon maintainer, Taylor Simpson, 2023/05/26
- [PULL 2/5] Hexagon (target/hexagon) Fix assignment to tmp registers, Taylor Simpson, 2023/05/26
- [PULL 1/5] Hexagon (tests/tcg/hexagon) Clean up Hexagon check-tcg tests, Taylor Simpson, 2023/05/26
- [PULL 4/5] Hexagon: fix outdated `hex_new_*` comments,
Taylor Simpson <=
- Re: [PULL 0/5] Hexagon update, Richard Henderson, 2023/05/26