[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 07/24] accel/tcg: Introduce page_check_range_empty
From: |
Alex Bennée |
Subject: |
Re: [PATCH 07/24] accel/tcg: Introduce page_check_range_empty |
Date: |
Mon, 03 Jul 2023 12:36:29 +0100 |
User-agent: |
mu4e 1.11.8; emacs 29.0.92 |
Richard Henderson <richard.henderson@linaro.org> writes:
> On 7/3/23 11:45, Alex Bennée wrote:
>> Richard Henderson <richard.henderson@linaro.org> writes:
>>
>>> Examine the interval tree to validate that a region
>>> has no existing mappings.
>>>
>>> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
>>> ---
>>> include/exec/cpu-all.h | 11 +++++++++++
>>> accel/tcg/user-exec.c | 7 +++++++
>>> 2 files changed, 18 insertions(+)
>>>
>>> diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h
>>> index 8018ce783e..5b2c230d52 100644
>>> --- a/include/exec/cpu-all.h
>>> +++ b/include/exec/cpu-all.h
>>> @@ -224,6 +224,17 @@ void page_set_flags(target_ulong start, target_ulong
>>> last, int flags);
>>> void page_reset_target_data(target_ulong start, target_ulong last);
>>> int page_check_range(target_ulong start, target_ulong len, int flags);
>>> +/**
>>> + * page_check_range_empty:
>>> + * @start: first byte of range
>>> + * @last: last byte of range
>> * Context: holding mmap lock
>
> Is this parsable magic? Two lines below I do say "memory lock must be
> held"...
Yeah - the kerneldoc describes it as:
* Context: Describes whether the function can sleep, what locks it takes,
* releases, or expects to be held. It can extend over multiple
* lines.
We use it in a couple of places in the existing code although mostly
referring to the BQL.
>
>
> r~
>
>> Otherwise:
>> Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
>>
--
Alex Bennée
Virtualisation Tech Lead @ Linaro