[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 28/38] gdbstub: lightly refactor connection to avoid snprintf
From: |
Alex Bennée |
Subject: |
[PULL 28/38] gdbstub: lightly refactor connection to avoid snprintf |
Date: |
Mon, 3 Jul 2023 14:44:17 +0100 |
This may be a bit too much to avoid an snprintf and the slightly dodgy
assign to a const variable. But hopefully not.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230630180423.558337-29-alex.bennee@linaro.org>
diff --git a/gdbstub/softmmu.c b/gdbstub/softmmu.c
index 99d994e6bf..f509b7285d 100644
--- a/gdbstub/softmmu.c
+++ b/gdbstub/softmmu.c
@@ -332,11 +332,9 @@ static void create_processes(GDBState *s)
int gdbserver_start(const char *device)
{
- trace_gdbstub_op_start(device);
-
- char gdbstub_device_name[128];
Chardev *chr = NULL;
Chardev *mon_chr;
+ g_autoptr(GString) cs = g_string_new(device);
if (!first_cpu) {
error_report("gdbstub: meaningless to attach gdb to a "
@@ -350,15 +348,16 @@ int gdbserver_start(const char *device)
return -1;
}
- if (!device) {
+ if (cs->len == 0) {
return -1;
}
- if (strcmp(device, "none") != 0) {
- if (strstart(device, "tcp:", NULL)) {
+
+ trace_gdbstub_op_start(cs->str);
+
+ if (g_strcmp0(cs->str, "none") != 0) {
+ if (g_str_has_prefix(cs->str, "tcp:")) {
/* enforce required TCP attributes */
- snprintf(gdbstub_device_name, sizeof(gdbstub_device_name),
- "%s,wait=off,nodelay=on,server=on", device);
- device = gdbstub_device_name;
+ g_string_append_printf(cs, ",wait=off,nodelay=on,server=on");
}
#ifndef _WIN32
else if (strcmp(device, "stdio") == 0) {
@@ -373,7 +372,7 @@ int gdbserver_start(const char *device)
* FIXME: it's a bit weird to allow using a mux chardev here
* and implicitly setup a monitor. We may want to break this.
*/
- chr = qemu_chr_new_noreplay("gdb", device, true, NULL);
+ chr = qemu_chr_new_noreplay("gdb", cs->str, true, NULL);
if (!chr) {
return -1;
}
--
2.39.2
- [PULL 03/38] gitlab: reduce testing scope of check-gcov, (continued)
- [PULL 03/38] gitlab: reduce testing scope of check-gcov, Alex Bennée, 2023/07/03
- [PULL 12/38] tests/lcitool: Bump fedora container versions, Alex Bennée, 2023/07/03
- [PULL 11/38] tests/lcitool: update to latest version, Alex Bennée, 2023/07/03
- [PULL 05/38] tests/tcg: add mechanism to handle plugin arguments, Alex Bennée, 2023/07/03
- [PULL 04/38] docs/devel: remind developers to run CI container pipeline when updating images, Alex Bennée, 2023/07/03
- [PULL 17/38] tests/avocado: Make the test_arm_bpim2u_gmac test more reliable, Alex Bennée, 2023/07/03
- [PULL 07/38] scripts/oss-fuzz: add a suppression for keymap, Alex Bennée, 2023/07/03
- [PULL 14/38] tests/lcitool: introduce qemu-minimal, Alex Bennée, 2023/07/03
- [PULL 15/38] tests/docker: convert riscv64-cross to lcitool, Alex Bennée, 2023/07/03
- [PULL 21/38] plugins: update lockstep to use g_memdup2, Alex Bennée, 2023/07/03
- [PULL 28/38] gdbstub: lightly refactor connection to avoid snprintf,
Alex Bennée <=
- [PULL 16/38] tests/avocado: update firmware to enable sbsa-ref/max, Alex Bennée, 2023/07/03
- [PULL 37/38] docs: Document security implications of debugging, Alex Bennée, 2023/07/03
- [PULL 19/38] plugins: force slow path when plugins instrument memory ops, Alex Bennée, 2023/07/03
- [PULL 33/38] linux-user: Emulate /proc/self/smaps, Alex Bennée, 2023/07/03
- [PULL 31/38] linux-user: Expose do_guest_openat() and do_guest_readlink(), Alex Bennée, 2023/07/03
- [PULL 13/38] tests/lcitool: add an explicit gcc-native package, Alex Bennée, 2023/07/03
- [PULL 27/38] docs/devel: introduce some key concepts for QOM development, Alex Bennée, 2023/07/03
- [PULL 20/38] plugins: fix memory leak while parsing options, Alex Bennée, 2023/07/03
- [PULL 29/38] gdbstub: Permit reverse step/break to provide stop response, Alex Bennée, 2023/07/03