Re: [PATCH] vhost: disable VHOST_OPS_DEBUG by default

[Philippe Mathieu-Daudé]

Hi,

On 17/7/23 19:44, Zhu Lingshan wrote:
> This commit disables VHOST_OPS_DEBUG by default
> These information are ususally only required in development
> environment
>
> Signed-off-by: Zhu Lingshan <lingshan.zhu@intel.com>
> ---
>   hw/virtio/vhost.c | 7 ++++++-
>   1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c
> index 82394331bf..ec435a3079 100644
> --- a/hw/virtio/vhost.c
> +++ b/hw/virtio/vhost.c
> @@ -29,7 +29,9 @@
>   #include "trace.h"
>   
>   /* enabled until disconnected backend stabilizes */
> -#define _VHOST_DEBUG 1
> +
> +/* uncomment macro _VHOST_DEBUG to enable VHOST_OPS_DEBUG */
> +/* #define _VHOST_DEBUG 1 */

Since you are looking at this, it would be more useful to
convert VHOST_OPS_DEBUG() to trace events (see for example
commit 163b8663b8 and other "Convert DPRINTF() debug macro
to trace events" commits).

Regards,

Phil.