[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 02/14] target/s390x: Fix CLM with M3=0
From: |
Ilya Leoshkevich |
Subject: |
[PATCH v3 02/14] target/s390x: Fix CLM with M3=0 |
Date: |
Thu, 20 Jul 2023 00:11:14 +0200 |
When the mask is zero, access exceptions should still be recognized for
1 byte at the second-operand address. CC should be set to 0.
Reviewed-by: David Hildenbrand <david@redhat.com>
Cc: qemu-stable@nongnu.org
Fixes: defb0e3157af ("s390x: Implement opcode helpers")
Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
---
target/s390x/tcg/mem_helper.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/target/s390x/tcg/mem_helper.c b/target/s390x/tcg/mem_helper.c
index f417fb1183c..d6dc8b32620 100644
--- a/target/s390x/tcg/mem_helper.c
+++ b/target/s390x/tcg/mem_helper.c
@@ -667,6 +667,11 @@ uint32_t HELPER(clm)(CPUS390XState *env, uint32_t r1,
uint32_t mask,
HELPER_LOG("%s: r1 0x%x mask 0x%x addr 0x%" PRIx64 "\n", __func__, r1,
mask, addr);
+ if (!mask) {
+ /* Recognize access exceptions for the first byte */
+ cpu_ldub_data_ra(env, addr, ra);
+ }
+
while (mask) {
if (mask & 8) {
uint8_t d = cpu_ldub_data_ra(env, addr, ra);
--
2.41.0
- [PATCH v3 00/14] target/s390x: Miscellaneous TCG fixes, part 2, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 03/14] target/s390x: Fix CONVERT TO LOGICAL/FIXED with out-of-range inputs, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 01/14] target/s390x: Make CKSM raise an exception if R2 is odd, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 05/14] target/s390x: Make MC raise specification exception when class >= 16, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 02/14] target/s390x: Fix CLM with M3=0,
Ilya Leoshkevich <=
- [PATCH v3 10/14] tests/tcg/s390x: Test CLM, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 07/14] target/s390x: Fix assertion failure in VFMIN/VFMAX with type 13, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 06/14] tcg/{i386, s390x}: Add earlyclobber to the op_add2's first output, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 04/14] target/s390x: Fix ICM with M3=0, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 13/14] tests/tcg/s390x: Test STPQ, Ilya Leoshkevich, 2023/07/19
- [PATCH v3 12/14] tests/tcg/s390x: Test MC, Ilya Leoshkevich, 2023/07/19