[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-8.1 5/6] acpi: x86: remove _ADR on host bridges
From: |
Igor Mammedov |
Subject: |
[PATCH for-8.1 5/6] acpi: x86: remove _ADR on host bridges |
Date: |
Thu, 20 Jul 2023 15:38:57 +0200 |
ACPI spec (since 2.0a) says
"
A device object must contain either an _HID object or
an _ADR object, but can contain both.
"
_ADR is used when device is attached to an ennumerable bus,
however hostbridge is not and uses dedicated _HID for
discovery, drop _ADR field.
It doesn't seem that having _ADR has a negative effects
OSes manage to tolerate that, but there is no point of
having it there. (only pc/q35 has it hostbridge description,
while others (microvm/arm) don't)
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 19d268ff59..bb12b0ad43 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -1464,7 +1464,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
sb_scope = aml_scope("_SB");
dev = aml_device("PCI0");
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A03")));
- aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
aml_append(dev, aml_name_decl("_UID", aml_int(pcmc->pci_root_uid)));
aml_append(dev, aml_pci_edsm());
aml_append(sb_scope, dev);
@@ -1479,7 +1478,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
dev = aml_device("PCI0");
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08")));
aml_append(dev, aml_name_decl("_CID", aml_eisaid("PNP0A03")));
- aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
aml_append(dev, aml_name_decl("_UID", aml_int(pcmc->pci_root_uid)));
aml_append(dev, build_q35_osc_method(!pm->pcihp_bridge_en));
aml_append(dev, aml_pci_edsm());
@@ -1593,7 +1591,6 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
aml_append(pkg, aml_eisaid("PNP0A08"));
aml_append(pkg, aml_eisaid("PNP0A03"));
aml_append(dev, aml_name_decl("_CID", pkg));
- aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
build_cxl_osc_method(dev);
} else if (pci_bus_is_express(bus)) {
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A08")));
--
2.39.3
- [PATCH for-8.1 0/6] x86: acpi pci fixes, Igor Mammedov, 2023/07/20
- [PATCH for-8.1 3/6] tests: acpi: x86: update expected blobs, Igor Mammedov, 2023/07/20
- [PATCH for-8.1 2/6] x86: acpi: workaround Windows not handling name references in Package properly, Igor Mammedov, 2023/07/20
- [PATCH for-8.1 5/6] acpi: x86: remove _ADR on host bridges,
Igor Mammedov <=
- [PATCH for-8.1 4/6] tests: acpi: whitelist expected blobs, Igor Mammedov, 2023/07/20
- [PATCH for-8.1 6/6] tests: acpi: update expected blobs, Igor Mammedov, 2023/07/20
- [PATCH for-8.1 1/6] tests: acpi: x86: whitelist expected blobs, Igor Mammedov, 2023/07/20