[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-8.2? v2 4/4] util/interval-tree: Use qatomic_read/set for
From: |
Peter Maydell |
Subject: |
Re: [PATCH for-8.2? v2 4/4] util/interval-tree: Use qatomic_read/set for rb_parent_color |
Date: |
Mon, 24 Jul 2023 12:53:17 +0100 |
On Sat, 22 Jul 2023 at 22:44, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> While less susceptible to optimization problems than left and right,
> interval_tree_iter_next also reads rb_parent(), so make sure that
> stores and loads are atomic.
>
> This goes further than technically required, changing all loads to
> be atomic, rather than simply the ones in the iteration side. But
> it doesn't really affect the code generation on the rebalance side
> and is cleaner to handle everything the same.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM