[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 04/33] linux-user: Remove qemu_host_page_size from create_elf_tab
From: |
Richard Henderson |
Subject: |
[PATCH 04/33] linux-user: Remove qemu_host_page_size from create_elf_tables |
Date: |
Fri, 18 Aug 2023 10:11:58 -0700 |
AT_PAGESZ is supposed to advertise the guest page size.
The random adjustment made here using qemu_host_page_size
does not match anything else within linux-user.
The idea here is good, but should be done more systemically
via adjustment to TARGET_PAGE_SIZE.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/elfload.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index 3648d7048d..b6af8f88aa 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2517,13 +2517,7 @@ static abi_ulong create_elf_tables(abi_ulong p, int
argc, int envc,
NEW_AUX_ENT(AT_PHDR, (abi_ulong)(info->load_addr + exec->e_phoff));
NEW_AUX_ENT(AT_PHENT, (abi_ulong)(sizeof (struct elf_phdr)));
NEW_AUX_ENT(AT_PHNUM, (abi_ulong)(exec->e_phnum));
- if ((info->alignment & ~qemu_host_page_mask) != 0) {
- /* Target doesn't support host page size alignment */
- NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(TARGET_PAGE_SIZE));
- } else {
- NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(MAX(TARGET_PAGE_SIZE,
- qemu_host_page_size)));
- }
+ NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(TARGET_PAGE_SIZE));
NEW_AUX_ENT(AT_BASE, (abi_ulong)(interp_info ? interp_info->load_addr :
0));
NEW_AUX_ENT(AT_FLAGS, (abi_ulong)0);
NEW_AUX_ENT(AT_ENTRY, info->entry);
--
2.34.1
- [PATCH 00/33] linux-user: Improve host and guest page size handling, Richard Henderson, 2023/08/18
- [PATCH 01/33] accel/tcg: Remove qemu_host_page_size from page_protect/page_unprotect, Richard Henderson, 2023/08/18
- [PATCH 02/33] linux-user: Adjust SVr4 NULL page mapping, Richard Henderson, 2023/08/18
- [PATCH 03/33] linux-user: Remove qemu_host_page_{size, mask} in probe_guest_base, Richard Henderson, 2023/08/18
- [PATCH 04/33] linux-user: Remove qemu_host_page_size from create_elf_tables,
Richard Henderson <=
- [PATCH 05/33] linux-user/hppa: Simplify init_guest_commpage, Richard Henderson, 2023/08/18
- [PATCH 06/33] linux-user/nios2: Remove qemu_host_page_size from init_guest_commpage, Richard Henderson, 2023/08/18
- [PATCH 07/33] linux-user/arm: Remove qemu_host_page_size from init_guest_commpage, Richard Henderson, 2023/08/18
- [PATCH 08/33] linux-user: Remove qemu_host_page_{size, mask} from mmap.c, Richard Henderson, 2023/08/18
- [PATCH 09/33] linux-user: Remove REAL_HOST_PAGE_ALIGN from mmap.c, Richard Henderson, 2023/08/18
- [PATCH 10/33] linux-user: Remove HOST_PAGE_ALIGN from mmap.c, Richard Henderson, 2023/08/18
- [PATCH 11/33] migration: Remove qemu_host_page_size, Richard Henderson, 2023/08/18
- [PATCH 12/33] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init, Richard Henderson, 2023/08/18
- [PATCH 13/33] softmmu/physmem: Remove qemu_host_page_size, Richard Henderson, 2023/08/18