[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 13/35] target/arm/ptw: Don't set fi->s1ptw for UnsuppAtomicUpdate
From: |
Peter Maydell |
Subject: |
[PULL 13/35] target/arm/ptw: Don't set fi->s1ptw for UnsuppAtomicUpdate fault |
Date: |
Thu, 24 Aug 2023 10:28:14 +0100 |
For an Unsupported Atomic Update fault where the stage 1 translation
table descriptor update can't be done because it's to an unsupported
memory type, this is a stage 1 abort (per the Arm ARM R_VSXXT). This
means we should not set fi->s1ptw, because this will cause the code
in the get_phys_addr_lpae() error-exit path to mark it as stage 2.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-id: 20230807141514.19075-2-peter.maydell@linaro.org
---
target/arm/ptw.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/arm/ptw.c b/target/arm/ptw.c
index 8f94100c61f..bafeb876ad7 100644
--- a/target/arm/ptw.c
+++ b/target/arm/ptw.c
@@ -701,7 +701,6 @@ static uint64_t arm_casq_ptw(CPUARMState *env, uint64_t
old_val,
if (unlikely(!host)) {
fi->type = ARMFault_UnsuppAtomicUpdate;
- fi->s1ptw = true;
return 0;
}
--
2.34.1
- [PULL 00/35] target-arm queue, Peter Maydell, 2023/08/24
- [PULL 05/35] qtest: irq_intercept_[out/in]: return FAIL if no intercepts are installed, Peter Maydell, 2023/08/24
- [PULL 03/35] qtest: implement named interception of out-GPIO, Peter Maydell, 2023/08/24
- [PULL 06/35] qtest: microbit-test: add tests for nRF51 DETECT, Peter Maydell, 2023/08/24
- [PULL 01/35] hw/gpio/nrf51: implement DETECT signal, Peter Maydell, 2023/08/24
- [PULL 02/35] qtest: factor out qtest_install_gpio_out_intercept, Peter Maydell, 2023/08/24
- [PULL 04/35] qtest: bail from irq_intercept_in if name is specified, Peter Maydell, 2023/08/24
- [PULL 28/35] target/arm/ptw: Load stage-2 tables from realm physical space, Peter Maydell, 2023/08/24
- [PULL 13/35] target/arm/ptw: Don't set fi->s1ptw for UnsuppAtomicUpdate fault,
Peter Maydell <=
- [PULL 24/35] target/arm/ptw: Set attributes correctly for MMU disabled data accesses, Peter Maydell, 2023/08/24
- [PULL 09/35] mips: Report an error when KVM_VM_MIPS_VZ is unavailable, Peter Maydell, 2023/08/24
- [PULL 16/35] target/arm/ptw: Pass ptw into get_phys_addr_pmsa*() and get_phys_addr_disabled(), Peter Maydell, 2023/08/24
- [PULL 11/35] accel/kvm: Free as when an error occurred, Peter Maydell, 2023/08/24
- [PULL 15/35] target/arm/ptw: Set s1ns bit in fault info more consistently, Peter Maydell, 2023/08/24
- [PULL 10/35] accel/kvm: Use negative KVM type for error propagation, Peter Maydell, 2023/08/24
- [PULL 32/35] target/arm/helper: Check SCR_EL3.{NSE, NS} encoding for AT instructions, Peter Maydell, 2023/08/24
- [PULL 35/35] target/arm: Fix 64-bit SSRA, Peter Maydell, 2023/08/24
- [PULL 30/35] target/arm: Skip granule protection checks for AT instructions, Peter Maydell, 2023/08/24
- [PULL 17/35] target/arm/ptw: Pass ARMSecurityState to regime_translation_disabled(), Peter Maydell, 2023/08/24