qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 08/20] linux-user: Load vdso image if available


From: Richard Henderson
Subject: Re: [PATCH v5 08/20] linux-user: Load vdso image if available
Date: Wed, 30 Aug 2023 15:08:14 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0

On 8/30/23 13:56, Philippe Mathieu-Daudé wrote:
+    for (unsigned i = 0, n = vdso->reloc_count; i < n; i++) {

Do we really need 'n'?

You should always have an loop invariant condition if possible.

vdso->reloc_count doesn't seem updated, but I get your point.

But the compiler doesn't know that -- it must assume that the store to *addr may overlap reloc_count.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]