Re: [PATCH v2 1/2] i386: Add support for SUCCOR feature

[Moger, Babu]

Hi John,

On 9/5/2023 10:01 AM, John Allen wrote:

> On Fri, Sep 01, 2023 at 11:30:53AM +0100, Joao Martins wrote:
> > On 26/07/2023 21:41, John Allen wrote:
> > > Add cpuid bit definition for the SUCCOR feature. This cpuid bit is required to
> > > be exposed to guests to allow them to handle machine check exceptions on AMD
> > > hosts.
> > >
> > > Reported-by: William Roche <william.roche@oracle.com>
> > > Signed-off-by: John Allen <john.allen@amd.com>
> > >         
> > I think this is matching the last discussion:
> >
> > 	Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
> >
> > The patch ordering doesn't look correct though. Perhaps we should expose succor
> > only after MCE is fixed so this patch would be the second, not the first?
> >       
> Yes, that makes sense. I will address this and send another version of
> the series with the correct ordering.
>
> > Also, this should in generally be OK for -cpu host, but might be missing a third
> > patch that adds "succor" to the AMD models e.g.
> >       
> Babu,
>
> I think we previously discussed adding this to the models later in a
> separate series. Is this your preferred course of action or can we add
> it with this series?
>

Yes. We can add it later as a separate series. We just added EPYC-Genoa. We don't want to add EPYC-Genoa-v2 at this point. We have few more features pending as well.

Thanks

Babu