Re: [PATCH v7 14/18] cpu: Call plugin hooks only when ready

[Philippe Mathieu-Daudé]

Hi Akihiko,

On 12/9/23 09:12, Akihiko Odaki wrote:
> The initialization and exit hooks will not affect the state of vCPU,

What about:

 qemu_plugin_vcpu_init_hook()
   -> plugin_cpu_update__locked()
      -> plugin_cpu_update__async()
         -> bitmap_copy(cpu->plugin_mask, ...)
            tcg_flush_jmp_cache(cpu)
            -> qatomic_set(&cpu->tb_jmp_cache->array[i].tb, ...)

?

> but they may depend on the state of vCPU. Therefore, it's better to
> call plugin hooks after the vCPU state is fully initialized and before
> it gets uninitialized.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
>   cpu.c                | 11 -----------
>   hw/core/cpu-common.c | 10 ++++++++++
>   2 files changed, 10 insertions(+), 11 deletions(-)