Re: [PATCH v2] hw/i386/pc: fix code comment on cumulative flash size

[Philippe Mathieu-Daudé]

On 12/9/23 17:55, Laszlo Ersek wrote:
> - The comment is incorrectly indented / formatted.
>
> - The comment states a 8MB limit, even though the code enforces a 16MB
>    limit.
>
> Both of these warts come from commit 0657c657eb37 ("hw/i386/pc: add max
> combined fw size as machine configuration option", 2020-12-09); clean them
> up.
>
> Arguably, it's also better to be consistent with the binary units (such as
> "MiB") that QEMU uses nowadays.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com> (supporter:PC)
> Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com> (supporter:PC)
> Cc: Paolo Bonzini <pbonzini@redhat.com> (maintainer:X86 TCG CPUs)
> Cc: Richard Henderson <richard.henderson@linaro.org> (maintainer:X86 TCG CPUs)
> Cc: Eduardo Habkost <eduardo@habkost.net> (maintainer:X86 TCG CPUs)
> Cc: qemu-trivial@nongnu.org
> Fixes: 0657c657eb37
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
> ---
>
> Notes:
>      v2:
>      
>      - use the binary units MiB, KiB, GiB comprehensively in the comment

I was going to suggest that ;)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>   hw/i386/pc.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)