I can try to improve it with your comments, but I have no idea of
x86 CPU features.
I will take a look.
> However, the dependency of user-mode emulation on KVM is really an
> implementation detail of QEMU. It's very much baked into linux-user and
> hard to remove, but I'm not sure it's a good idea to add more #ifdef
> CONFIG_USER_ONLY around KVM code.
Do you rather v3 then?
20230911142729.25548-1-philmd@linaro.org/" rel="noreferrer noreferrer" target="_blank">https://lore.kernel.org/qemu-devel/20230911142729.25548-1-philmd@linaro.org/
No, if we want a small patch it is better to replace kvm_enabled() with CONFIG_KVM, and also follow Kevin's suggestion to make it fail at compile time.
Having stub prototypes was done because we expected the compiler to remove the dead code.
Paolo