[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 07/11] qapi: fix example of query-rocker-of-dpa-flows comm
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v2 07/11] qapi: fix example of query-rocker-of-dpa-flows command |
Date: |
Thu, 14 Sep 2023 15:50:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) |
Victor Toso <victortoso@redhat.com> writes:
> Example output has a comment embedded in the array. Remove it.
> The end result is a list of size 1.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/rocker.json | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/qapi/rocker.json b/qapi/rocker.json
> index 31ce0b36f6..858e4f4a45 100644
> --- a/qapi/rocker.json
> +++ b/qapi/rocker.json
> @@ -249,8 +249,7 @@
> # "cookie": 0,
> # "action": {"goto-tbl": 10},
> # "mask": {"in-pport": 4294901760}
> -# },
> -# {...more...},
> +# }
> # ]}
> ##
> { 'command': 'query-rocker-of-dpa-flows',
The schema patches in this series fix typos, except for this patch and
the next one, which drop "more of the same omitted for brevity" text. I
believe you drop the text because it doesn't parse as JSON.
Fine if the example still make sense afterwards. Do they?
Shortening examples is a reasonable thing to do. Perhaps we should
adopt a conventional way to do it, and teach the proposed generator to
cope with it. What do you think?
- [PATCH v2 01/11] qapi: fix example of get-win32-socket command, (continued)
- [PATCH v2 01/11] qapi: fix example of get-win32-socket command, Victor Toso, 2023/09/11
- [PATCH v2 03/11] qapi: fix example of cancel-vcpu-dirty-limit command, Victor Toso, 2023/09/11
- [PATCH v2 02/11] qapi: fix example of dumpdtb command, Victor Toso, 2023/09/11
- [PATCH v2 04/11] qapi: fix example of set-vcpu-dirty-limit command, Victor Toso, 2023/09/11
- [PATCH v2 05/11] qapi: fix example of calc-dirty-rate command, Victor Toso, 2023/09/11
- [PATCH v2 06/11] qapi: fix example of NETDEV_STREAM_CONNECTED event, Victor Toso, 2023/09/11
- [PATCH v2 08/11] qapi: fix example of query-spice command, Victor Toso, 2023/09/11
- [PATCH v2 07/11] qapi: fix example of query-rocker-of-dpa-flows command, Victor Toso, 2023/09/11
- [PATCH v2 09/11] qapi: fix example of query-blockstats command, Victor Toso, 2023/09/11
- [PATCH v2 10/11] qapi: meson: add test flag to allow skip generators, Victor Toso, 2023/09/11
- Re: [PATCH v2 00/11] Validate and test qapi examples, Markus Armbruster, 2023/09/14