[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] hw/pci: Add all Data Object Types
From: |
Jonathan Cameron |
Subject: |
Re: [PATCH 1/3] hw/pci: Add all Data Object Types |
Date: |
Fri, 15 Sep 2023 15:46:37 +0100 |
On Fri, 15 Sep 2023 21:27:21 +1000
Alistair Francis <alistair23@gmail.com> wrote:
> Add all of the defined protocols/features from the PCIe-SIG
> "Table 6-32 PCI-SIG defined Data Object Types (Vendor ID = 0001h)"
Which version of the specification? These references can rot.
Obviously it's below, but who knows if anyone will look there ;)
It's already changed in 6.1 and the table has more entries.
I'd just change this to say, Add all Data Object Types defined in PCIe r6.0
> table.
>
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> include/hw/pci/pcie_doe.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/hw/pci/pcie_doe.h b/include/hw/pci/pcie_doe.h
> index 87dc17dcef..15d94661f9 100644
> --- a/include/hw/pci/pcie_doe.h
> +++ b/include/hw/pci/pcie_doe.h
> @@ -46,6 +46,8 @@ REG32(PCI_DOE_CAP_STATUS, 0)
>
> /* PCI-SIG defined Data Object Types - r6.0 Table 6-32 */
> #define PCI_SIG_DOE_DISCOVERY 0x00
> +#define PCI_SIG_DOE_CMA 0x01
> +#define PCI_SIG_DOE_SECURED_CMA 0x02
>
> #define PCI_DOE_DW_SIZE_MAX (1 << 18)
> #define PCI_DOE_PROTOCOL_NUM_MAX 256