[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 05/22] parallels: return earler in fail_format branch in parall
From: |
Denis V. Lunev |
Subject: |
[PULL v2 05/22] parallels: return earler in fail_format branch in parallels_open() |
Date: |
Thu, 21 Sep 2023 09:54:43 +0200 |
We do not need to perform any deallocation/cleanup if wrong format is
detected.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Reviewed-by: Alexander Ivanov <alexander.ivanov@virtuozzo.com>
---
block/parallels.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/block/parallels.c b/block/parallels.c
index ae006e7fc7..12f38cf70b 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -1232,7 +1232,8 @@ static int parallels_open(BlockDriverState *bs, QDict
*options, int flags,
fail_format:
error_setg(errp, "Image not in Parallels format");
- ret = -EINVAL;
+ return -EINVAL;
+
fail:
/*
* "s" object was allocated by g_malloc0 so we can safely
--
2.34.1
- [PULL v2 00/22] implement discard operation for Parallels images, Denis V. Lunev, 2023/09/21
- [PULL v2 01/22] parallels: fix formatting in bdrv_parallels initialization, Denis V. Lunev, 2023/09/21
- [PULL v2 03/22] parallels: fix memory leak in parallels_open(), Denis V. Lunev, 2023/09/21
- [PULL v2 04/22] parallels: invent parallels_opts_prealloc() helper to parse prealloc opts, Denis V. Lunev, 2023/09/21
- [PULL v2 02/22] parallels: mark driver as supporting CBT, Denis V. Lunev, 2023/09/21
- [PULL v2 07/22] parallels: refactor path when we need to re-check image in parallels_open, Denis V. Lunev, 2023/09/21
- [PULL v2 09/22] tests: ensure that image validation will not cure the corruption, Denis V. Lunev, 2023/09/21
- [PULL v2 08/22] parallels: create mark_used() helper which sets bit in used bitmap, Denis V. Lunev, 2023/09/21
- [PULL v2 05/22] parallels: return earler in fail_format branch in parallels_open(),
Denis V. Lunev <=
- [PULL v2 06/22] parallels: return earlier from parallels_open() function on error, Denis V. Lunev, 2023/09/21
- [PULL v2 13/22] tests: fix broken deduplication check in parallels format test, Denis V. Lunev, 2023/09/21
- [PULL v2 10/22] parallels: fix broken parallels_check_data_off(), Denis V. Lunev, 2023/09/21
- [PULL v2 19/22] parallels: naive implementation of parallels_co_pdiscard, Denis V. Lunev, 2023/09/21
- [PULL v2 15/22] parallels: accept multiple clusters in mark_used(), Denis V. Lunev, 2023/09/21
- [PULL v2 16/22] parallels: update used bitmap in allocate_cluster, Denis V. Lunev, 2023/09/21
- [PULL v2 14/22] tests: test self-cure of parallels image with duplicated clusters, Denis V. Lunev, 2023/09/21
- [PULL v2 12/22] parallels: collect bitmap of used clusters at open, Denis V. Lunev, 2023/09/21
- [PULL v2 21/22] parallels: naive implementation of parallels_co_pwrite_zeroes, Denis V. Lunev, 2023/09/21
- [PULL v2 17/22] parallels: naive implementation of allocate_clusters with used bitmap, Denis V. Lunev, 2023/09/21